Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building the documentation #146

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

fviernau
Copy link
Contributor

The support for Sphinx version 7 has been implemented in rdt-themes, but hasn't yet been released [1]. Currently, the build uses Sphinx version 7 which fails with [2].

Use a Sphinx version prior to 7 in order to fix that issue.

[1] readthedocs/sphinx_rtd_theme#1463
[2] UndefinedError("'style' is undefined")

The support for `Sphinx` version 7 has been implemented in
`rdt-themes`, but hasn't yet been released [1]. Currently, the build
uses `Sphinx` version 7 which fails with [2].

Use a `Sphinx` version prior to 7 in order to fix that issue.

[1] readthedocs/sphinx_rtd_theme#1463
[2] `UndefinedError("'style' is undefined")`

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks++

@TG1999 TG1999 merged commit f288e25 into aboutcode-org:main Sep 25, 2023
8 of 10 checks passed
leocardao added a commit to leocardao/e3-core that referenced this pull request Oct 4, 2023
Last time, the doc build failed because rtd was not fully supported by
Sphinx7.
See:
    - readthedocs/sphinx_rtd_theme#1463
    - aboutcode-org/python-inspector#146

This problem has now been corrected, so we want to use the latest
rtd-compatible version of Sphinx.

Also fix the requirements version used in order to avoid future build
failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants