Fix/ibpp license detection issue#4864
Open
kumarasantosh wants to merge 4 commits intoaboutcode-org:developfrom
Open
Fix/ibpp license detection issue#4864kumarasantosh wants to merge 4 commits intoaboutcode-org:developfrom
kumarasantosh wants to merge 4 commits intoaboutcode-org:developfrom
Conversation
When a gemspec uses a Ruby constant for the version field like: s.version = Elasticsearch::API::VERSION s.version = Faraday::VERSION scancode was storing the constant name as the version string. These constants cannot be resolved without executing Ruby code. Add is_ruby_version_constant() to detect Ruby constant expressions (containing :: namespace separator or bare uppercase constant names) and return None for the version instead of storing an unresolvable constant string. Also fixes the download_url and api_data_url which were generating invalid URLs with the constant name embedded. Fixes aboutcode-org#3129 Signed-off-by: kumarasantosh <santosh.pulikond02@gmail.com>
Signed-off-by: kumarasantosh <santosh.pulikond02@gmail.com>
licenses: add IBPP License v1.1 detection - Add ibpp_ref.RULE for reference-style detection - Add ibpp_intro.RULE for header/copyright line detection - Add test data for IBPP interference with passwdqc block Signed-off-by: kumarasantosh <santosh.pulikond02@gmail.com>
kumarasantosh
force-pushed
the
fix/ibpp-license-detection-issue
branch
from
30504c0 to
09a4197
Compare
Signed-off-by: kumarasantosh <santosh.pulikond02@gmail.com>
kumarasantosh
force-pushed
the
fix/ibpp-license-detection-issue
branch
from
b2f4026 to
2eae344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3553
Summary
Adds detection support for the IBPP License v1.1, which was not being detected when scanning the Wt project's
licenses.md.Root Cause
The
passwdqcBSD-style warranty disclaimer immediately before the IBPP section was interfering with detection — the scanner absorbed those tokens and failed to recognize the IBPP block as a separate license. removing the passwdqc disclaimer caused IBPP to be detected correctly.