Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where certain files would cause Errno::EPIPE exception to be raised #9

Merged
merged 5 commits into from
Dec 26, 2019

Conversation

abrom
Copy link
Owner

@abrom abrom commented Oct 20, 2019

Fixes #7

Use Open3 instead of IO library for calling to Tika.

@abrom
Copy link
Owner Author

abrom commented Oct 20, 2019

FYI @rywall. Keeps the default still using the IO pipe method, but allows you to use the Ruby Shell alternative with an initialiser param (or via the class .read method).

@rywall
Copy link

rywall commented Oct 20, 2019

@abrom perfect, thanks!

@abrom
Copy link
Owner Author

abrom commented Oct 30, 2019

@rywall I was having some major flake issues with the solution I'd originally come up with. So I've gone back to the drawing board and come up with another solution that appears to be able to read your problem file without any errors.

I've tested it on a bunch of my files as far as I can tell it's all looking good..

However I'd really like to get your input on whether this works for you on a larger set of data before merging. Can you please check this branch out and try it on some of the other files you've previously had problems with (and of course check that there aren't any regressions).

@abrom abrom changed the title Add option for client read to use Ruby Shell to pipe data Fix issue where certain files would cause Errno::EPIPE exception to be raised Oct 30, 2019
@abrom abrom merged commit 66807cc into master Dec 26, 2019
@abrom abrom deleted the add-shell-pipe-read-option branch December 26, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errno::EPIPE on certain png images
2 participants