NOISSUE - Update Rules Service #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
requested changes
Jan 8, 2025
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
approved these changes
Jan 9, 2025
felixgateru
pushed a commit
that referenced
this pull request
Jan 10, 2025
* update re service Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * add status update for rules Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * revert docker compose changes Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor pr
What does this do?
This pr does some minor changes to the rules service. We change the status endpoint to delete endpoint as it deletes the rule and update some of the environment variables as it is a magistrala service not supermq. We also update the port since
6008is used by the UI backend service.Which issue(s) does this PR fix/relate to?
noissue
Have you included tests for your changes?
no
Did you document any new/modified feature?
no
Notes