Skip to content

Commit

Permalink
Some minor tidy-up.
Browse files Browse the repository at this point in the history
  • Loading branch information
judgej committed Mar 25, 2015
1 parent 260d78f commit b7ffe1e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 2 additions & 2 deletions src/Academe/SagePay/Helper/Helper.php
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<?php

namespace Academe\SagePay\Helper;

/**
* Base model abstract for models that generate XML as their main output.
* TODO: split the currency stuff out to a separate abstract. Currency details
* are needed by the main service classes, but it makes no sense having
* ServieceAbstract inheriting the XML functions here.
*/

namespace Academe\SagePay\Helper;

use Academe\SagePay\Exception as Exception;

class Helper
Expand Down
6 changes: 2 additions & 4 deletions src/Academe/SagePay/Metadata/Iso4217.php
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
<?php

namespace Academe\SagePay\Metadata;

/**
* List of ISO4217 currency codes.
* See: http://en.wikipedia.org/wiki/ISO_4217
* Source: http://www.currency-iso.org/en/home/tables/table-a1.html
* Not all will be supported by SagePay.
*/

namespace Academe\SagePay\Metadata;

class Iso4217
{
/**
* Currency code list.
* TODO: store this data as a PHP array, then it is easier to manipulate
* without the need to convert. Or maybe convert once and cache.
*/

public static $data = array (
Expand Down
2 changes: 1 addition & 1 deletion src/Academe/SagePay/Metadata/Transaction.php
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ class Transaction
"chars": ["A", "a", "^", "9", " ", "+", "'", "/", "&", ":", ",", ".", "-", "n", "("],
"min": 1,
"max": 40,
"default": "academe",
"default": "3F7A4119-8671-464F-A091-9E59EB47B80C",
"source": [
"server-registration"
],
Expand Down

0 comments on commit b7ffe1e

Please sign in to comment.