Merge pull request #9 from aimeoscom/master

Fixes isSuccessful() which returned true in almost all cases
academe · Jun 12, 2020 · 0f4a8a2 · 0f4a8a2
2 parents c9705e6 + 985c582
commit 0f4a8a2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Messages/NotificationValuesTrait.php b/src/Messages/NotificationValuesTrait.php
@@ -168,8 +168,8 @@ public function getApprovalCode()
      */
     public function isSuccessful()
     {
-        return $this->getTransactionState() === static::TRANSACTION_STATE_BILLED
-            || $this->getOperationStatus() === static::OPERATION_STATUS_OK;
+        return $this->getOperation() === 'CONFIRMATION' && $this->getTransactionState() === static::TRANSACTION_STATE_BILLED
+            || $this->getReturnCode() === 'PROFILE_USED' && $this->getOperationStatus() === static::OPERATION_STATUS_OK;
     }
 
     /**