Return a 404 rather than a 500 if the oetition id is not valid.

academe · Feb 15, 2019 · 8df425e · 8df425e
1 parent 0d2a2db
commit 8df425e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php
@@ -10,7 +10,7 @@
 
 class ReportController extends Controller
 {
-    public function simpleOverview(int $petitionNumber = null)
+    public function simpleOverview($petitionNumber = null)
     {
         if ($petitionNumber !== null) {
             $petition = Petition::where('petition_number', '=', $petitionNumber)

diff --git a/routes/web.php b/routes/web.php
@@ -11,11 +11,13 @@
 |
 */
 
-Route::redirect('/', '/overview');
+Route::middleware('throttle:30,1')->group(function () {
+    // There is just the one page for now.
 
-// ReportController
+    Route::redirect('/', '/overview');
+
+    // ReportController
 
-Route::middleware('throttle:30,1')->group(function () {
     Route::get('/overview/{petitionNumber?}', 'ReportController@simpleOverview')
         ->name('overview');
 });