Skip to content

Homework submission -- add logout feature #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alizinha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Homework submission -- add logout feature #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package="com.github.mobile">



<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.GET_ACCOUNTS" />
<uses-permission android:name="android.permission.MANAGE_ACCOUNTS" />
Expand Down
1 change: 1 addition & 0 deletions app/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@

<string name="app_name">GitHub</string>
<string name="home">Home</string>
<string name="logout">Logout</string>
<string name="news">News</string>
<string name="issues">Issues</string>
<string name="gists">Gists</string>
Expand Down
15 changes: 15 additions & 0 deletions app/src/main/java/com/github/mobile/accounts/LoginActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import android.view.View.OnKeyListener;
import android.widget.ArrayAdapter;
import android.widget.AutoCompleteTextView;
import android.widget.Button;
import android.widget.CheckBox;
import android.widget.CompoundButton;
import android.widget.CompoundButton.OnCheckedChangeListener;
Expand Down Expand Up @@ -171,6 +172,20 @@ public void onCreate(Bundle savedInstanceState) {
loginText = finder.find(R.id.et_login);
passwordText = finder.find(R.id.et_password);

//This is where I'd put a logout button. Great for a user with multiple Github accounts!

// ViewFinder addingLogOut = new ViewFinder(this);
// addingLogOut = finder.find(R.id.et_logout);
// Button logout = (Button)findViewById(R.id.logOut);
// logout.setOnClickListener(new View.OnClickListener() {
// @Override
// public void onClick(View v) {
//
// }
// });



final Intent intent = getIntent();
username = intent.getStringExtra(PARAM_USERNAME);
authTokenType = intent.getStringExtra(PARAM_AUTHTOKEN_TYPE);
Expand Down