Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create scheduler (resolves #646) #687

Merged
merged 18 commits into from
Aug 9, 2022
Merged

Conversation

marvinroman
Copy link
Contributor

Added new command deploy:initial which is where we will put everything that we need to run at boot time. Then we only add this command into entrypoint script and make all changes within this command.

Made update to entrypoint script.

Added new command db:refresh which chains migrate:fresh & db:seed commands.

Added schedule to run command db:refresh to run nightly on environments tagged with staging or local.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #687 (1f76b62) into dev (c6e0c0f) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev     #687      +/-   ##
============================================
- Coverage     92.93%   92.33%   -0.60%     
- Complexity     1111     1116       +5     
============================================
  Files           196      198       +2     
  Lines          3240     3261      +21     
============================================
  Hits           3011     3011              
- Misses          229      250      +21     
Impacted Files Coverage Δ
app/Console/Commands/DatabaseRefresh.php 0.00% <0.00%> (ø)
app/Console/Commands/DeployInitial.php 0.00% <0.00%> (ø)
app/Console/Kernel.php 37.50% <0.00%> (-62.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@greatislander greatislander changed the title Feat/create scheduler feat: create scheduler Aug 5, 2022
Copy link
Collaborator

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions/questions. Also wondering where the schedule is run on the staging environment?

@greatislander greatislander added enhancement New feature or request infrastructure This issue is related to hosting and continuous deployment of the platform labels Aug 5, 2022
@greatislander greatislander changed the title feat: create scheduler feat: create scheduler (resolves #646) Aug 5, 2022
Co-authored-by: Ned Zimmerman <ned@bight.dev>
@marvinroman
Copy link
Contributor Author

Also wondering where the schedule is run on the staging environment?

Currently we aren't running a cron to hit scheduler in staging. We would need to open an issue and have Jure implement one into the Kube.

@marvinroman marvinroman marked this pull request as draft August 8, 2022 17:34
@marvinroman
Copy link
Contributor Author

Reverted workflows, the changes seemed to cause testing failures.
Removed --step from migrate:fresh.
Removed test for commands.

@greatislander greatislander marked this pull request as ready for review August 8, 2022 18:24
@greatislander greatislander merged commit 0f86ae3 into dev Aug 9, 2022
@greatislander greatislander deleted the feat/create-scheduler branch August 9, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure This issue is related to hosting and continuous deployment of the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants