class-declaration-abstractness-changed with adding rules

accordproject · Dec 22, 2024 · b358dd9 · b358dd9
1 parent eb1fde0
commit b358dd9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/concerto-analysis/src/compare-config.ts b/packages/concerto-analysis/src/compare-config.ts
@@ -53,6 +53,8 @@ export const defaultCompareConfig: CompareConfig = {
         'optional-property-added': CompareResult.PATCH,
         'required-property-removed': CompareResult.MAJOR,
         'optional-property-removed': CompareResult.MAJOR,
+        'class-declaration-abstract-to-concrete': CompareResult.MINOR,
+        'class-declaration-concrete-to-abstract': CompareResult.MAJOR, 
         'namespace-changed': CompareResult.ERROR,
         'enum-value-added': CompareResult.PATCH,
         'enum-value-removed': CompareResult.MAJOR,

diff --git a/packages/concerto-analysis/src/comparers/class-declarations.ts b/packages/concerto-analysis/src/comparers/class-declarations.ts
@@ -54,14 +54,22 @@ const classDeclarationTypeChanged: ComparerFactory = (context) => ({
         if (aType === bType) {
             return;
         }
-
+        if(aType !== bType){
+            context.report({
+                key: `class-declaration-type-changed`,
+                message: `The ${aType} "${a.getName()}" changed from ${aType} to ${bType}`,
+                element: a
+            });
+        }
+
+        //add Logic for abstractness changes
         const isAbstract = (declaration) => declaration.isAbstract();
         if (isAbstract(a) !== isAbstract(b)) {
             const changeType = isAbstract(a) ? 'abstract to concrete' : 'concrete to abstract';
-            const changeSeverity = isAbstract(a) ? 'minor' : 'major';
+            const changeKey =isAbstract(a) ? `class-declaration-abstract-to-concrete` : `class-declaration-concrete-to-abstract`;
             context.report({
-                key: 'class-declaration-abstractness-changed',
-                message: `The class "${a.getName()}" changed from ${changeType} (${changeSeverity} change).`,
+                key: changeKey,
+                message: `The class "${a.getName()}" changed from ${changeType}.`,
                 element: a
             });
         }