Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonathan/add options jsdoc #729

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Jonathan/add options jsdoc #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f56f36a
feat(map): add jsdoc for enableMapType option
jonathan-casey Oct 10, 2023
1773c12
chore(*): update changelog
jonathan-casey Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/concerto-core/api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ class AstModelManager extends BaseModelManager {
+ void constructor(object?)
}
class BaseModelManager {
+ void constructor(object?,boolean?,Object?,boolean?,boolean?,processFile?)
+ void constructor(object?,boolean?,Object?,boolean?,boolean?,boolean?,processFile?)
+ boolean isModelManager()
+ boolean isStrict()
+ Object accept(Object,Object)
Expand Down
3 changes: 3 additions & 0 deletions packages/concerto-core/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
# Note that the latest public API is documented using JSDocs and is available in api.txt.
#

Version 3.13.1 {6b09c1c58abcc77eecbb44e375c2efb8} 2023-10-03
- Add enableMapType option to BaseModelManager options

Version 3.13.0 {125b7f97f8740628b2629b2793384cc7} 2023-10-03
- Update DecoratorManager to support multiple value compare
- Create DecoratorManager.validate method to validate structure of decorator command set
Expand Down
1 change: 1 addition & 0 deletions packages/concerto-core/lib/basemodelmanager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ class BaseModelManager {
* @param {Object} [options.regExp] - An alternative regular expression engine.
* @param {boolean} [options.metamodelValidation] - When true, modelfiles will be validated
* @param {boolean} [options.addMetamodel] - When true, the Concerto metamodel is added to the model manager
* @param {boolean} [options.enableMapType] - When true, the Concerto Map Type feature is enabled
* @param {*} [processFile] - how to obtain a concerto AST from an input to the model manager
*/
constructor(options, processFile) {
Expand Down
4 changes: 4 additions & 0 deletions packages/concerto-core/types/lib/basemodelmanager.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ declare class BaseModelManager {
* @param {Object} [options.regExp] - An alternative regular expression engine.
* @param {boolean} [options.metamodelValidation] - When true, modelfiles will be validated
* @param {boolean} [options.addMetamodel] - When true, the Concerto metamodel is added to the model manager
* @param {boolean} [options.enableMapType] - When true, the Concerto Map Type feature is enabled
* @param {*} [processFile] - how to obtain a concerto AST from an input to the model manager
*/
constructor(options?: {
strict?: boolean;
regExp?: any;
metamodelValidation?: boolean;
addMetamodel?: boolean;
enableMapType?: boolean;
}, processFile?: any);
processFile: any;
modelFiles: {};
Expand All @@ -42,7 +44,9 @@ declare class BaseModelManager {
regExp?: any;
metamodelValidation?: boolean;
addMetamodel?: boolean;
enableMapType?: boolean;
};
enableMapType: boolean;
metamodelModelFile: any;
/**
* Returns true
Expand Down