feat(error): resolved pr comments

Signed-off-by: Santanu Roy <edu.santanu12@gmail.com>

packages/concerto-core/api.txt

@@ -344,6 +344,6 @@ class Serializer {
    + Resource fromJSON(Object,Object?,boolean,boolean,number?) 
 }
 class TypeNotFoundException extends BaseException {
-   + void constructor(string,string|,string) 
+   + void constructor(string,string|,string,string) 
    + string getTypeName() 
 }

packages/concerto-core/changelog.txt

@@ -24,7 +24,7 @@
 # Note that the latest public API is documented using JSDocs and is available in api.txt.
 #
 
-Version 3.13.3 {b286dfdeeb654d25be7c5f9cc6305e38} 2023-11-07
+Version 3.13.3 {8f59b43e6071c4d3ae42e94476142f7a} 2023-11-07
 - Added DCS and vocabulary extraction support for decoratorManager
 - Added errortype to BaseException and used that to define error types in introspect 
 

packages/concerto-core/lib/introspect/stringvalidator.js

@@ -71,7 +71,7 @@ class StringValidator extends Validator{
                 this.regex = new CustomRegExp(validator.pattern, validator.flags);
             }
             catch(exception) {
-                this.reportError(field.getName(), exception.message,ErrorCodes.REGEX_VALIDATOR_EXCEPTION);
+                this.reportError(field.getName(), exception.message, ErrorCodes.REGEX_VALIDATOR_EXCEPTION);
             }
         }
     }

packages/concerto-core/lib/introspect/validator.js

@@ -51,7 +51,7 @@ class Validator {
      * @throws {Error} throws an error to report the message
      */
     reportError(id, msg, errorType=ErrorCodes.DEFAULT_VALIDATOR_EXCEPTION) {
-        throw new BaseException('Validator error for field `' + id + '`. ' + this.getFieldOrScalarDeclaration().getFullyQualifiedName() + ': ' + msg ,undefined,errorType);
+        throw new BaseException('Validator error for field `' + id + '`. ' + this.getFieldOrScalarDeclaration().getFullyQualifiedName() + ': ' + msg, undefined, errorType);
     }
 
     /**

packages/concerto-core/lib/typenotfoundexception.js

@@ -14,7 +14,7 @@
 
 'use strict';
 
-const { BaseException } = require('@accordproject/concerto-util');
+const { BaseException, ErrorCodes } = require('@accordproject/concerto-util');
 const Globalize = require('./globalize');
 
 /**
@@ -31,16 +31,17 @@ class TypeNotFoundException extends BaseException {
      * @param {string} typeName - fully qualified type name.
      * @param {string|undefined} message - error message.
      * @param {string} component - the optional component which throws this error
+     * @param {string} errorType - the error code related to the error
      */
-    constructor(typeName, message, component) {
+    constructor(typeName, message, component, errorType = ErrorCodes.TYPE_NOT_FOUND_EXCEPTION) {
         if (!message) {
             const formatter = Globalize.messageFormatter('typenotfounderror-defaultmessage');
             message = formatter({
                 typeName: typeName
             });
         }
 
-        super(message, component);
+        super(message, component, errorType);
         this.typeName = typeName;
     }
 

packages/concerto-core/types/lib/typenotfoundexception.d.ts

@@ -7,6 +7,15 @@ export = TypeNotFoundException;
  * @memberof module:concerto-core
  */
 declare class TypeNotFoundException extends BaseException {
+    /**
+     * Constructor. If the optional 'message' argument is not supplied, it will be set to a default value that
+     * includes the type name.
+     * @param {string} typeName - fully qualified type name.
+     * @param {string|undefined} message - error message.
+     * @param {string} component - the optional component which throws this error
+     * @param {string} errorType - the error code related to the error
+     */
+    constructor(typeName: string, message: string | undefined, component: string, errorType?: string);
     typeName: string;
     /**
      * Get the name of the type that was not found.

packages/concerto-util/lib/errorcodes.js

@@ -20,5 +20,7 @@ const DEFAULT_BASE_EXCEPTION = 'DefaultBaseException';
 const DEFAULT_VALIDATOR_EXCEPTION = 'DefaultValidatorException';
 // exception code for regex validator format error
 const REGEX_VALIDATOR_EXCEPTION = 'RegexValidatorException';
+// base exception for Type not found
+const TYPE_NOT_FOUND_EXCEPTION = 'TypeNotFoundException';
 
-module.exports = {DEFAULT_BASE_EXCEPTION, DEFAULT_VALIDATOR_EXCEPTION, REGEX_VALIDATOR_EXCEPTION};
+module.exports = {DEFAULT_BASE_EXCEPTION, DEFAULT_VALIDATOR_EXCEPTION, REGEX_VALIDATOR_EXCEPTION, TYPE_NOT_FOUND_EXCEPTION};

packages/concerto-util/types/lib/errorcodes.d.ts

@@ -1,3 +1,4 @@
 export const DEFAULT_BASE_EXCEPTION: "DefaultBaseException";
 export const DEFAULT_VALIDATOR_EXCEPTION: "DefaultValidatorException";
 export const REGEX_VALIDATOR_EXCEPTION: "RegexValidatorException";
+export const TYPE_NOT_FOUND_EXCEPTION: "TypeNotFoundException";