Fix(GUI) Stretched Logo on Mobile and Safari #86

nitro56565 · 2024-07-17T18:25:00Z

Closes #84 #82

Description

This pull request addresses issue #84 , which highlights the problem of the logo appearing stretched on mobile devices and in the Safari browser. The issue was caused by browser-defined CSS, which has now been fixed. The logo will maintain its aspect ratio and display correctly on all devices and browsers, including mobile devices and Safari.

Changes

Ensured the logo's dimensions are set to auto to maintain its aspect ratio.
Used CSS media queries to adjust the logo size for different screen sizes.
Tested and fixed Safari-specific CSS issues.

Screenshots or Video

Related Issues

Issue Stretched logo on mobile and safari #84 Fix styling for safari #82
Pull Request Fix(GUI) Stretched Logo on Mobile and Safari #86

Author Checklist

Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
Vital features and changes captured in unit and/or integration tests
Commits messages follow AP format
Extend the documentation, if necessary
Merging to main from fork:branchname

netlify · 2024-07-17T18:25:19Z

✅ Deploy Preview for ap-template-playground ready!

Name	Link
🔨 Latest commit	`fbcb79b`
🔍 Latest deploy log	https://app.netlify.com/sites/ap-template-playground/deploys/669a565e0a28ad0008a1f9b4
😎 Deploy Preview	https://deploy-preview-86--ap-template-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nitro56565 · 2024-07-18T14:58:03Z

Hi @Vinyl-Davyl can you please review the code

Vinyl-Davyl · 2024-07-18T15:11:52Z

Hi @Vinyl-Davyl can you please review the code

Hi @nitro56565 looks great.
Can you ensure you sign the DCO Checks?

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

nitro56565 · 2024-07-18T15:26:15Z

@Vinyl-Davyl done

nitro56565 · 2024-07-18T15:26:23Z

@Vinyl-Davyl done

Vinyl-Davyl

changes and fixes for this have been made(i.e ConcertoEditor) in the most recent PR before this.

could you try reviewing the PR before this, see where it’s being made so you could make adjustments to avoid front running merge conflicts.

nitro56565 · 2024-07-18T15:27:31Z

alright I'll check that

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

nitro56565 · 2024-07-18T15:52:15Z

I have merged your pr for concerto editor please check and let me know if there is any issue.

sanketshevkar · 2024-07-19T10:06:07Z

src/components/Navbar.tsx

@@ -105,7 +105,7 @@ function Navbar({ scrollToExplore }: { scrollToExplore: any }) {
            preview={false}
            style={{
              paddingRight: screens.md ? "1.5em" : "10px",
-              height: "26px",
+              height: "26px", maxWidth: screens.md ? '184.17px' : '36.67px',


This is fine for now. @Vinyl-Davyl @nitro56565 can we please look into having a consistent unit for styles, we are using em, px both. Let's please fix this as well.

sanketshevkar · 2024-07-19T10:12:30Z

@nitro56565 what is the concerto editor change about?

Vinyl-Davyl · 2024-07-19T11:02:25Z

src/components/Navbar.tsx

@@ -105,7 +105,7 @@ function Navbar({ scrollToExplore }: { scrollToExplore: any }) {
            preview={false}
            style={{
              paddingRight: screens.md ? "1.5em" : "10px",


okay @nitro56565 can you change this: 1.5em in the paddingRight, to the equivalent of 24 pixels from the base format 16px.

so change 1.5em to 24px to ensure consistency here!

alright I'll do that

@Vinyl-Davyl done with these changes

nitro56565 · 2024-07-19T11:02:35Z

@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

sanketshevkar · 2024-07-19T11:30:16Z

@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.

Are @Vinyl-Davyl changes already merged? If yes, you had to rebase to the main. We shouldn't be seeing the diff for ConcertoEditor.

…and encoded template data in URLs (accordproject#85) * chore: updated spinner style Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> * feat: functionality to generate shareable links that include the encoded template data with lz-string implementation Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> * chore: concertoEditor build fixes Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> * chore: build fixes Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> * fix: review changes Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> * feat: URL versioning Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com> --------- Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>

nitro56565 · 2024-07-19T11:37:00Z

@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.

Are @Vinyl-Davyl changes already merged? If yes, you had to rebase to the main. We shouldn't be seeing the diff for ConcertoEditor.

His changes are not yet merged should I rebase it back to the last changes as it was? but it would create a build error will that be fine?

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

…b.com/nitro56565/template-playground into nitro56565/i84/safari-header-logo-bug

nitro56565 · 2024-07-19T12:11:23Z

Hey @Vinyl-Davyl I have merged your PR which was just pushed on the main branch with mine the code looks fine at my end can you please review. @sanketshevkar

Vinyl-Davyl · 2024-07-19T12:15:08Z

@sanketshevkar there was type declaration issue in concerto which I fixed because my build was failing, but @Vinyl-Davyl had already fixed it in his new PR therefore I matched his changes with mine to avoid merge conflict.

Are @Vinyl-Davyl changes already merged? If yes, you had to rebase to the main. We shouldn't be seeing the diff for ConcertoEditor.

His changes are not yet merged should I rebase it back to the last changes as it was? but it would create a build error will that be fine?

Hi @nitro56565 the changes has been merged now. I think you should rebase to main / pull the latest changes to ensure sync and eliminate the blocker you have on build. Also you should scope the changes to the "Stretched Logo on Mobile and Safari" issue i.e the Navbar.tsx file alone now, then you should be good to go.

nitro56565 requested a review from a team as a code owner July 17, 2024 18:25

nitro56565 changed the title ~~Fix Stretched Logo on Mobile and Safari (#84)~~ Fix(GUI) Stretched Logo on Mobile and Safari Jul 17, 2024

nitro56565 added 2 commits July 18, 2024 20:53

safari-logo-fix

0c7f931

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

error match & monaco model typo fix

d9258e5

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

nitro56565 force-pushed the nitro56565/i84/safari-header-logo-bug branch from 77d5208 to d9258e5 Compare July 18, 2024 15:23

Vinyl-Davyl suggested changes Jul 18, 2024

View reviewed changes

matched concerto editor code with latest pr

e767ccf

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

sanketshevkar reviewed Jul 19, 2024

View reviewed changes

Vinyl-Davyl reviewed Jul 19, 2024

View reviewed changes

changed unit from em to px

3f6c22e

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

nitro56565 added 5 commits July 19, 2024 17:26

safari-logo-fix

f86c3e1

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

error match & monaco model typo fix

56ff1dd

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

matched concerto editor code with latest pr

31b65eb

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

changed unit from em to px

af8799f

Signed-off-by: Mahesh Patil <nitro56565@gmail.com>

Merge branch 'nitro56565/i84/safari-header-logo-bug' of https://githu…

fbcb79b

…b.com/nitro56565/template-playground into nitro56565/i84/safari-header-logo-bug

nitro56565 closed this Jul 19, 2024

nitro56565 mentioned this pull request Jul 19, 2024

fix(GUI): Stretched Logo on Safari Browser #87

Merged

5 tasks

nitro56565 deleted the nitro56565/i84/safari-header-logo-bug branch July 19, 2024 17:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix(GUI) Stretched Logo on Mobile and Safari #86

Fix(GUI) Stretched Logo on Mobile and Safari #86

nitro56565 commented Jul 17, 2024 •

edited

Loading

netlify bot commented Jul 17, 2024 •

edited

Loading

nitro56565 commented Jul 18, 2024

Vinyl-Davyl commented Jul 18, 2024

nitro56565 commented Jul 18, 2024

nitro56565 commented Jul 18, 2024

Vinyl-Davyl left a comment

nitro56565 commented Jul 18, 2024

nitro56565 commented Jul 18, 2024

sanketshevkar Jul 19, 2024

sanketshevkar commented Jul 19, 2024

Vinyl-Davyl Jul 19, 2024

nitro56565 Jul 19, 2024

nitro56565 Jul 19, 2024

nitro56565 commented Jul 19, 2024

sanketshevkar commented Jul 19, 2024

nitro56565 commented Jul 19, 2024

nitro56565 commented Jul 19, 2024

Vinyl-Davyl commented Jul 19, 2024 •

edited

Loading

Fix(GUI) Stretched Logo on Mobile and Safari #86

Fix(GUI) Stretched Logo on Mobile and Safari #86

Conversation

nitro56565 commented Jul 17, 2024 • edited Loading

Closes #84 #82

Description

Changes

Screenshots or Video

Related Issues

Author Checklist

netlify bot commented Jul 17, 2024 • edited Loading

✅ Deploy Preview for ap-template-playground ready!

nitro56565 commented Jul 18, 2024

Vinyl-Davyl commented Jul 18, 2024

nitro56565 commented Jul 18, 2024

nitro56565 commented Jul 18, 2024

Vinyl-Davyl left a comment

Choose a reason for hiding this comment

nitro56565 commented Jul 18, 2024

nitro56565 commented Jul 18, 2024

sanketshevkar Jul 19, 2024

Choose a reason for hiding this comment

sanketshevkar commented Jul 19, 2024

Vinyl-Davyl Jul 19, 2024

Choose a reason for hiding this comment

nitro56565 Jul 19, 2024

Choose a reason for hiding this comment

nitro56565 Jul 19, 2024

Choose a reason for hiding this comment

nitro56565 commented Jul 19, 2024

sanketshevkar commented Jul 19, 2024

nitro56565 commented Jul 19, 2024

nitro56565 commented Jul 19, 2024

Vinyl-Davyl commented Jul 19, 2024 • edited Loading

nitro56565 commented Jul 17, 2024 •

edited

Loading

netlify bot commented Jul 17, 2024 •

edited

Loading

Vinyl-Davyl commented Jul 19, 2024 •

edited

Loading