Resource::formatPersons(): sort persons before joining so the result …

…is stable
acdh-oeaw · Oct 23, 2024 · 7e305ec · 7e305ec
1 parent f2200d1
commit 7e305ec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/acdhOeaw/arche/biblatex/Resource.php b/src/acdhOeaw/arche/biblatex/Resource.php
@@ -378,6 +378,7 @@ private function formatPersons(array $properties,
                 }
             }
         }
+        sort($persons);
         return join(' and ', $persons);
     }
 

diff --git a/tests/ResourceTest.php b/tests/ResourceTest.php
@@ -69,7 +69,7 @@ public function testAll(): void {
   author = {Steiner, Guenther},
   editoratype = {compiler},
   booktitle = {Die Große Transformation},
-  bookauthor = {{} and Steiner, Guenther and {} and {} and {}},
+  bookauthor = {Steiner, Guenther and {} and {} and {} and {}},
   note = {sha1:ba29f9d179bb963516cf5d4c7ca268b9555a0602},
   keywords = {Bundesländer, Föderalismus, Verwaltung, Zwischenkriegszeit},
   abstract = {Das Protokoll behandelt die 3. Länderkonferenz.}
@@ -98,7 +98,7 @@ public function testLive(): void {
   author = {Steiner, Guenther},
   editoratype = {compiler},
   booktitle = {Die Große Transformation},
-  bookauthor = {Megner, Karl and Steiner, Guenther and Helfert, Veronika and Garstenauer, Theresa and Becker, Peter},
+  bookauthor = {Becker, Peter and Garstenauer, Theresa and Helfert, Veronika and Megner, Karl and Steiner, Guenther},
   note = {sha1:ba29f9d179bb963516cf5d4c7ca268b9555a0602},
   keywords = {Bundesländer, Föderalismus, Verwaltung, Zwischenkriegszeit},
   abstract = {Das Protokoll behandelt die 3. Länderkonferenz.}
-Original file line number
+Diff line change
@@ Expand Up / @@ -378,6 +378,7 @@ private function formatPersons(array $properties, @@
                     }
                 }
             }
+            sort($persons);
             return join(' and ', $persons);
         }
@@ Expand Down @@