Skip to content

⚡ Fix favicon: use static PNG instead of broken dynamic SVG #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acfranzen merged 2 commits into from
Feb 5, 2026
Merged

⚡ Fix favicon: use static PNG instead of broken dynamic SVG #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
040020c
⚡ Fix favicon: use static PNG instead of broken dynamic SVG
acfranzen Feb 5, 2026
94bacb3
Add logo icon to dashboard header, fix font
acfranzen Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/app/icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
51 changes: 0 additions & 51 deletions src/app/icon.tsx
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion src/components/dashboard/DashboardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@
<div className="flex items-center justify-between h-16 px-4 md:px-6">
{/* Logo */}
<div className="flex items-center gap-2 sm:gap-4">
<h1 className="font-serif text-xl sm:text-2xl font-bold text-foreground">
<img

Check warning on line 50 in src/components/dashboard/DashboardHeader.tsx

View workflow job for this annotation

GitHub Actions / Lint, Type Check & Build (20) 

Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element

Check warning on line 50 in src/components/dashboard/DashboardHeader.tsx

View workflow job for this annotation

GitHub Actions / Lint, Type Check & Build (22) 

Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
src="/icon.png"
alt="Glance"
className="h-8 w-8"
/>
Copy link

@cursor cursor bot Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logo image references non-existent public file path

Medium Severity

The <img src="/icon.png"> element references a file at the URL path /icon.png, which requires the file to exist in the public/ directory. However, the PR description states the icon.png is being placed in src/app/ for favicon purposes. Files in src/app/ are served by Next.js's file-based metadata conventions (for favicons) but are not accessible at root URLs for <img> elements. The public/ directory currently contains icon.svg but no icon.png, so this image will fail to load with a 404 error.

Fix in Cursor Fix in Web

<h1 className="text-xl sm:text-2xl font-semibold text-foreground tracking-tight">
Glance
</h1>
<span className="hidden sm:inline text-xs text-muted-foreground">
Expand Down
Loading