Skip to content

Commit

Permalink
fix: add rubocop-factory_bot and rubocop-capybara as they've been…
Browse files Browse the repository at this point in the history
… pulled out of `rubocop-rspec`
  • Loading branch information
G-Rath committed Aug 4, 2023
1 parent 6b2e1b5 commit 5eb845f
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 29 deletions.
8 changes: 5 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# configuration which is copied into generated applications.
---
require:
- rubocop-capybara
- rubocop-factory_bot
- rubocop-performance
- rubocop-rails
- rubocop-rspec
Expand Down Expand Up @@ -233,9 +235,6 @@ RSpec/MultipleExpectations:
RSpec/ExampleLength:
Max: 30

RSpec/FactoryBot/SyntaxMethods:
Enabled: false

Rails/LexicallyScopedActionFilter:
Exclude:
- 'app/controllers/application_controller.rb'
Expand All @@ -246,3 +245,6 @@ RSpec/RepeatedExample:

RSpec/MultipleMemoizedHelpers:
Max: 10

FactoryBot/SyntaxMethods:
Enabled: false
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
source "https://rubygems.org"

gem "rubocop", "~> 1.31"
gem "rubocop-capybara", "~> 2.18"
gem "rubocop-factory_bot", "~> 2.23"
gem "rubocop-performance", "~> 1.14"
gem "rubocop-rails", "~> 2.15"
gem "rubocop-rspec", "~> 2.12"
56 changes: 34 additions & 22 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,49 +1,59 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (7.0.4.3)
activesupport (7.0.6)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
ast (2.4.2)
concurrent-ruby (1.2.2)
i18n (1.12.0)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
json (2.6.2)
minitest (5.18.0)
parallel (1.22.1)
parser (3.1.2.0)
json (2.6.3)
language_server-protocol (3.17.0.3)
minitest (5.19.0)
parallel (1.23.0)
parser (3.2.2.3)
ast (~> 2.4.1)
rack (3.0.6.1)
racc
racc (1.7.1)
rack (3.0.8)
rainbow (3.1.1)
regexp_parser (2.5.0)
rexml (3.2.5)
rubocop (1.31.2)
regexp_parser (2.8.1)
rexml (3.2.6)
rubocop (1.55.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.1.0.0)
parser (>= 3.2.2.3)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.18.0, < 2.0)
rubocop-ast (>= 1.28.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.19.1)
parser (>= 3.1.1.0)
rubocop-performance (1.14.3)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.18.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.23.1)
rubocop (~> 1.33)
rubocop-performance (1.18.0)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.15.2)
rubocop-rails (2.20.2)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.7.0, < 2.0)
rubocop-rspec (2.12.1)
rubocop (~> 1.31)
ruby-progressbar (1.11.0)
rubocop (>= 1.33.0, < 2.0)
rubocop-rspec (2.23.0)
rubocop (~> 1.33)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
ruby-progressbar (1.13.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (2.2.0)
unicode-display_width (2.4.2)

PLATFORMS
arm64-darwin-21
Expand All @@ -52,6 +62,8 @@ PLATFORMS

DEPENDENCIES
rubocop (~> 1.31)
rubocop-capybara (~> 2.18)
rubocop-factory_bot (~> 2.23)
rubocop-performance (~> 1.14)
rubocop-rails (~> 2.15)
rubocop-rspec (~> 2.12)
Expand Down
2 changes: 2 additions & 0 deletions variants/backend-base/Gemfile.tt
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ group :development do

gem "brakeman", require: false
gem "rubocop", require: false
gem "rubocop-factory_bot", require: false
gem "rubocop-capybara", require: false
gem "rubocop-performance", require: false
gem "rubocop-rails", require: false
gem "rubocop-rspec", require: false
Expand Down
9 changes: 5 additions & 4 deletions variants/backend-base/rubocop.yml.tt
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
---
require:
- rubocop-capybara
- rubocop-factory_bot
- rubocop-performance
- rubocop-rails
- rubocop-rspec
- rubocop-capybara

# Built-in config:
# https://github.com/bbatsov/rubocop/blob/master/config/default.yml
Expand Down Expand Up @@ -274,9 +275,6 @@ RSpec/MultipleExpectations:
RSpec/ExampleLength:
Max: 30

RSpec/FactoryBot/SyntaxMethods:
Enabled: false

Rails/LexicallyScopedActionFilter:
Exclude:
- 'app/controllers/application_controller.rb'
Expand All @@ -287,3 +285,6 @@ RSpec/RepeatedExample:

RSpec/MultipleMemoizedHelpers:
Max: 10

FactoryBot/SyntaxMethods:
Enabled: false

0 comments on commit 5eb845f

Please sign in to comment.