Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 341 modernise secret handling #392

Merged
merged 31 commits into from
Aug 25, 2023
Merged

Issue 341 modernise secret handling #392

merged 31 commits into from
Aug 25, 2023

Commits on Oct 22, 2022

  1. Remove confusing comment

    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    1ad3bc1 View commit details
    Browse the repository at this point in the history

  2. Modernise generated secrets.yml 

    * Stop generating both `secrets.yml` and `secrets.example.yml`. Our `secrets.yml`
  loads everything from the ENV so it is safe to check in and having a
  separate example file is unnecessary.
* Add secrets demonstrating how to configure ActiveRecord encrypted attributes
  without using Rails encrypted credentials.
    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    70c7dd4 View commit details
    Browse the repository at this point in the history

  3. Stop creating .env from example.env because bin/setup already does this

    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    cde294b View commit details
    Browse the repository at this point in the history

  4. Remove Rails encrypted credentials files to avoid confusion 

    We have chosen not to use Rails encrypted credentials so we remove the
files generated by Rails to avoid confusion.
    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    983d868 View commit details
    Browse the repository at this point in the history

  5. Load non-sensitive app config from config/app.yml 

    * Put explanatory comment at top of `config/app.yml` to explain that
  non-sensitive config should go here and sensitive config should go in
  `config/secrets.yml`
* Update existing references to `mail_from` config item in the app
    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    d100d0c View commit details
    Browse the repository at this point in the history

  6. Update variants/devise/template.rb 

    Co-authored-by: Gareth Jones <gareth.jones@ackama.com>
    @eoinkelly @G-Rath
    eoinkelly and G-Rath authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    96f2c05 View commit details
    Browse the repository at this point in the history

  7. Generate sensible default secrets for AR encryption

    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3a6ef51 View commit details
    Browse the repository at this point in the history

  8. Fail early if an expected secret is not available in the ENV

    @eoinkelly
    eoinkelly committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    8a5492d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Set new required env vars in CI

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    7a0a026 View commit details
    Browse the repository at this point in the history

  2. Fix CI

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    0019a73 View commit details
    Browse the repository at this point in the history

  3. CI fix attempt 2

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    64fb8f2 View commit details
    Browse the repository at this point in the history

  4. Add debug logging to db:encryption:init

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    4c8981a View commit details
    Browse the repository at this point in the history

  5. Fix chicken & egg of needing ENV vars to exist before we can set thei… 

    …r values
    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    59d8370 View commit details
    Browse the repository at this point in the history

  6. Undo previous attempted fix

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    1633c3c View commit details
    Browse the repository at this point in the history

  7. Use safe_load as suggested by rubocop

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    08737b9 View commit details
    Browse the repository at this point in the history

  8. Tone down output

    @eoinkelly
    eoinkelly committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    6a7dc47 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Merge branch 'main' into issue-341-modernise-secrets

    @eoinkelly
    eoinkelly authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9461bb2 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Merge branch 'main' into issue-341-modernise-secrets

    @eoinkelly
    eoinkelly committed May 5, 2023
    Configuration menu
    Copy the full SHA
    a93845c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Check for placeholder secrets at app boot

    @eoinkelly
    eoinkelly committed May 6, 2023
    Configuration menu
    Copy the full SHA
    d161f74 View commit details
    Browse the repository at this point in the history

  2. Generate separate ActiveRecord encryption secrets for example.env and… 

    … .env
    @eoinkelly
    eoinkelly committed May 6, 2023
    Configuration menu
    Copy the full SHA
    d8f3293 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Update variants/backend-base/config/app.yml 

    Co-authored-by: Gareth Jones <gareth.jones@ackama.com>
    @eoinkelly @G-Rath
    eoinkelly and G-Rath authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    944a40e View commit details
    Browse the repository at this point in the history

  2. Update variants/backend-base/config/initializers/check_env.rb 

    Co-authored-by: Gareth Jones <gareth.jones@ackama.com>
    @eoinkelly @G-Rath
    eoinkelly and G-Rath authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    61a18ba View commit details
    Browse the repository at this point in the history

  3. Update variants/backend-base/config/initializers/check_env.rb 

    Co-authored-by: Gareth Jones <gareth.jones@ackama.com>
    @eoinkelly @G-Rath
    eoinkelly and G-Rath authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    3247099 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into issue-341-modernise-secrets

    @eoinkelly
    eoinkelly committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    6a78028 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'issue-341-modernise-secrets' of github.com:ackama/rails… 

    …-template into issue-341-modernise-secrets
    @eoinkelly
    eoinkelly committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    c5eacb6 View commit details
    Browse the repository at this point in the history

  6. Improve comment based on PR feedback

    @eoinkelly
    eoinkelly committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    8f91295 View commit details
    Browse the repository at this point in the history

  7. Update variants/backend-base/example.env.tt 

    Co-authored-by: Gareth Jones <gareth.jones@ackama.com>
    @eoinkelly @G-Rath
    eoinkelly and G-Rath authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    24f1153 View commit details
    Browse the repository at this point in the history

  8. Add missing end removed by merge

    @eoinkelly
    eoinkelly committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    3801920 View commit details
    Browse the repository at this point in the history

  9. Ensure new auto-generated example.env secrets not used in prod

    @eoinkelly
    eoinkelly committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    31acec3 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary tweaking of db:encryption secrets

    @eoinkelly
    eoinkelly committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    c6f4dc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'main' into issue-341-modernise-secrets

    @eoinkelly
    eoinkelly committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7cc48c8 View commit details
    Browse the repository at this point in the history