Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI checks against Ruby 3.1 #449

Closed
wants to merge 5 commits into from

Conversation

eoinkelly
Copy link
Contributor

Fixes #445. Includes changes from #441 (which are required to successfully build now) so will wait for #441 to land before making this ready for merge.

@G-Rath
Copy link
Contributor

G-Rath commented Jul 16, 2023

I think we should continue to run against the latest patch version of Ruby (rather than locking via .ruby-version) because in theory it should always work, and that should help catch if it doesn't (remember we also run CI once a week which notifies at least me if it fails).

Ideally sort of given #448 we should probably run against at least a couple of versions of Ruby to ensure compatibility - ideally ideally it would be good to run against say most recent stable and upcoming latest, though when @robotdana set that up on another public project of ours it seemed very unstable but maybe there's some way we could pull in like "latest prerelease" or something rather than the most latest commit version of Ruby?

@eoinkelly
Copy link
Contributor Author

@G-Rath I have a slight preference for a .ruby-version file because it automatically syncs up local dev and CI but I also see the value of your approach. I'm fine with making the smaller change (your approach). It looks like #444 is unblocked now so I'll update this PR to run CI against 3.2 instead of 3.1

@eoinkelly
Copy link
Contributor Author

Closing in favour of #452

@eoinkelly eoinkelly closed this Jul 23, 2023
@eoinkelly eoinkelly deleted the issue-445-run-ci-against-ruby-3-1 branch July 23, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run CI against ruby 3.1
2 participants