feat: setup jest in Stimulus variants
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
frontend-test-variant
branch
2 times, most recently
from
9d9fca2
to
f69989f
Compare
G-Rath
requested review from
eoinkelly,
lukeify,
halles,
joshmcarthur,
robotdana,
robramsaynz,
JacobBriggsAckama,
brooke-m and
hopkincame
robotdana
approved these changes
Aug 6, 2023
Yup that's tracked by #422 but I want to do it in another PR |
lukeify
reviewed
Aug 9, 2023
G-Rath
force-pushed
the
frontend-test-variant
branch
3 times, most recently
from
f6e00c1
to
1655045
Compare
lukeify
approved these changes
Aug 11, 2023
G-Rath
force-pushed
the
frontend-test-variant
branch
from
1655045
to
93031a4
Compare
|
tbh I feel like this should be pulled into either its own variants or into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to write tests directly for Stimulus controllers (and JavaScript in general) which can be nice as they're faster than the current alternative (system tests).