fix: import @testing-library/jest-dom matchers in their own setup script
#472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
all-together
branch
3 times, most recently
from
a27235a
to
9f87b69
Compare
…cript Technically we could just add the import to `setupFilesAfterEnv`, but then they'd not get picked up by TypeScript since we wouldn't actually be "importing" them in a TS file.
G-Rath
changed the title
@testing-library/jest-dom matchers in their own setup script
G-Rath
requested review from
eoinkelly,
lukeify,
halles,
joshmcarthur,
robotdana,
robramsaynz,
JacobBriggsAckama,
brooke-m and
hopkincame
JacobBriggsAckama
approved these changes
Aug 14, 2023
robotdana
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on the fence about switching to have just a single
setup.js|tsfile as then we might have to do more logic on adding to that without conflicting, but it might be fine as we're not really doing that much and I don't expect we'll have more to add in the future...Still we can make that switch later - for now I just want to get CI back in the green.