Attempt to merge latest upstream #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…single letter columns
fixed an issue with col_name causing it to fail generating names for …
Refactor Creek::Sheet class
Get date attribute from workbookPr and use it during dates conversion
Values formatted as percentage values should not be divided by 100. They are already stored as decimals (0.15 for 15%).
* Add image parsing support * Refactor image parsing logic and fix some issues * Add comments to new methods for image parsing in sheet * Add tests for parsing images * Refactor image parsing, add comments and update tests * Update Readme
* Fix tmp image path * Fix specs for excel without images
I changed the Readme format to markdown, fixed some typos and added syntax highlighting.
* Update nokogiri version
Needed to upgrade to Ruby 2.4
* Updated rspec version so tests can pass.
* Change to use rspec 3 syntax
* Convert specs to RSpec 3.6.0 syntax with Transpec
This conversion is done by Transpec 3.3.0 with the following command:
transpec
* 25 conversions
from: obj.should
to: expect(obj).to
* 22 conversions
from: == expected
to: eq(expected)
* 1 conversion
from: obj.should_not
to: expect(obj).not_to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
* Added logic to contend with the default namespace having a prefix
Added logic to contend with the default namespace having a prefix. Only
addressed on the 'book'
* Handle sheets files already containing xl/ prefix
Sheets generated by certain libraries already prefix xl/
* Bump httparty to 0.15 and Ruby to >= 2.0.0
Plenty of bugfixes were committed to httparty since 0.14
Some of those fixes address very serious bugs and memory leaks
Httparty 0.15 requires Ruby >= 2.0.0, and now so does this gem
* support for inlineStr cell type
#52) * Updated gemspec to use latest version of nokogiri (1.8.0) which works with Ruby 2.4. Modified example code slightly in README to match project folder name ('spec' instead of 'specs'). * Updated rubyzip version.
* replace HTTParty with http.rb in gemspec * replace httparty use with http.rb
* Always return a Time object for DateTime cells * Fix specs for DateTime parsing
* Added mapping cell ids with header column name * Added readme description * Exclude masOS files in .gitignore * Added tests and small refactoring
`BigDecimal.new` has been removed in ruby 2.7. Therefore converting big decimals is broken. Use `BigDecimal(value)` instead. https://ruby-doc.org/stdlib-2.7.1/libdoc/bigdecimal/rdoc/BigDecimal.html
This fixes headers being messed up when #simple_rows is called multiple times.
* Use local_name to ignore namespaces when enumerating a sheet's rows. * Include XML namespace when constructing the shared strings dictionary * Respect the configured namespace when parsing a sheet's rows Instead of using local_name, which throws away the namespace prefix, identify the configured namespace prefix (if there is one) and use that when looking for nodes in the SAX parsing loop.
* add missing frozen_string_litteral * limit string allocations in Creek::Sheet#rows_generator
* added rubocop * applied lint * added lint check in ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.