Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Terraform 1.9.8 Upgrades #115

Merged
merged 8 commits into from
Nov 14, 2024
Merged

Conversation

clee231
Copy link
Contributor

@clee231 clee231 commented Nov 13, 2024

This makes updates to the Terraform stacks managing our Azure account.

Notable changes:

@clee231 clee231 self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Terraform plan in azure/terraform/stacks/sysadmin-demo in the prod workspace
With var files: azure/terraform/stacks/sysadmin-demo/configuration/prod.tfvars

Plan: 1 to add, 0 to change, 2 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
-   destroy

Terraform will perform the following actions:

  # azurerm_dns_a_record.ayush_data will be destroyed
  # (because azurerm_dns_a_record.ayush_data is not in configuration)
-   resource "azurerm_dns_a_record" "ayush_data" {
-       fqdn                = "ayushispanda.acmuic.org." -> null
-       id                  = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/resourceGroups/acm-general/providers/Microsoft.Network/dnsZones/acmuic.org/A/ayushispanda" -> null
-       name                = "ayushispanda" -> null
-       records             = [
-           "131.193.46.70",
        ] -> null
-       resource_group_name = "acm-general" -> null
-       ttl                 = 30 -> null
-       zone_name           = "acmuic.org" -> null
#        (1 unchanged attribute hidden)
    }

  # azurerm_dns_a_record.chasetest will be created
+   resource "azurerm_dns_a_record" "chasetest" {
+       fqdn                = (known after apply)
+       id                  = (known after apply)
+       name                = "chasetest"
+       records             = [
+           "127.0.0.1",
        ]
+       resource_group_name = "acm-general"
+       ttl                 = 60
+       zone_name           = "acmuic.org"
    }

  # azurerm_dns_a_record.jose_a_record will be destroyed
  # (because azurerm_dns_a_record.jose_a_record is not in configuration)
-   resource "azurerm_dns_a_record" "jose_a_record" {
-       fqdn                = "joseiscool.acmuic.org." -> null
-       id                  = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/resourceGroups/acm-general/providers/Microsoft.Network/dnsZones/acmuic.org/A/joseiscool" -> null
-       name                = "joseiscool" -> null
-       records             = [
-           "131.193.46.70",
        ] -> null
-       resource_group_name = "acm-general" -> null
-       ttl                 = 30 -> null
-       zone_name           = "acmuic.org" -> null
#        (1 unchanged attribute hidden)
    }

Plan: 1 to add, 0 to change, 2 to destroy.

✅ Plan applied in Terraform Apply on Azure #54

Copy link

github-actions bot commented Nov 13, 2024

Terraform plan in azure/terraform/stacks/acm-general in the prod workspace
With var files: azure/terraform/stacks/acm-general/configuration/prod.tfvars

Plan: 0 to add, 0 to change, 2 to destroy. Changes to Outputs.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-   destroy

Terraform will perform the following actions:

  # azurerm_role_assignment.terraform_sysadmin_demo_dns will be destroyed
  # (because azurerm_role_assignment.terraform_sysadmin_demo_dns is not in configuration)
-   resource "azurerm_role_assignment" "terraform_sysadmin_demo_dns" {
-       id                                     = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/providers/Microsoft.Authorization/roleAssignments/e9b75556-5b2b-1020-ab42-d4d20b9e5099" -> null
-       name                                   = "e9b75556-5b2b-1020-ab42-d4d20b9e5099" -> null
-       principal_id                           = "99519fba-1292-4dbe-a41a-9937c0f5a0a6" -> null
-       principal_type                         = "ServicePrincipal" -> null
-       role_definition_id                     = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/providers/Microsoft.Authorization/roleDefinitions/befefa01-2a29-4197-83a8-272ff33ce314" -> null
-       role_definition_name                   = "DNS Zone Contributor" -> null
-       scope                                  = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7" -> null
#        (4 unchanged attributes hidden)
    }

  # azurerm_role_assignment.terraform_sysadmin_demo_reader will be destroyed
  # (because azurerm_role_assignment.terraform_sysadmin_demo_reader is not in configuration)
-   resource "azurerm_role_assignment" "terraform_sysadmin_demo_reader" {
-       id                                     = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/providers/Microsoft.Authorization/roleAssignments/72c17cbf-d1db-7bc7-fb81-b8b419ec08e8" -> null
-       name                                   = "72c17cbf-d1db-7bc7-fb81-b8b419ec08e8" -> null
-       principal_id                           = "99519fba-1292-4dbe-a41a-9937c0f5a0a6" -> null
-       principal_type                         = "ServicePrincipal" -> null
-       role_definition_id                     = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/providers/Microsoft.Authorization/roleDefinitions/acdd72a7-3385-48ef-bd42-f606fba81ae7" -> null
-       role_definition_name                   = "Reader" -> null
-       scope                                  = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7" -> null
#        (4 unchanged attributes hidden)
    }

Plan: 0 to add, 0 to change, 2 to destroy.

Changes to Outputs:
!~  azurerm_dns_zone_acm_uic = {
        id                        = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/resourceGroups/acm-general/providers/Microsoft.Network/dnsZones/acmuic.org"
        name                      = "acmuic.org"
!~      number_of_record_sets     = 59 -> 69
        tags                      = {}
#        (4 unchanged attributes hidden)
    }
-   externaldns_sp_appid     = "f995b4bc-00a0-4912-9a1a-da9f74407cb8" -> null
+   externaldns_sp_clientid  = "f995b4bc-00a0-4912-9a1a-da9f74407cb8"

✅ Plan applied in Terraform Apply on Azure #54

Outputs
azurerm_dns_zone_acm_uic = {
    id                        = "/subscriptions/2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7/resourceGroups/acm-general/providers/Microsoft.Network/dnsZones/acmuic.org"
    max_number_of_record_sets = 10000
    name                      = "acmuic.org"
    name_servers              = [
        "ns1-06.azure-dns.com.",
        "ns2-06.azure-dns.net.",
        "ns3-06.azure-dns.org.",
        "ns4-06.azure-dns.info.",
    ]
    number_of_record_sets     = 69
    resource_group_name       = "acm-general"
    tags                      = {}
    timeouts                  = null
}
default_resource_group   = "acm-general"
externaldns_sp_clientid  = "f995b4bc-00a0-4912-9a1a-da9f74407cb8"
externaldns_sp_keyid     = "4417adde-2f44-480f-ae52-685557438430"
externaldns_sp_password  = (sensitive value)
subscription_id          = "2f98793b-7e2f-4f03-ac5b-7b2ec934dcd7"
tenant_id                = "cad5e02f-bae4-42d6-a06e-4377dd3e386f"

@clee231 clee231 enabled auto-merge (squash) November 13, 2024 04:40
Copy link
Contributor

@SohamG SohamG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not open source but whatevs lol

@clee231 clee231 merged commit a2db111 into main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants