Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - Copy layout from teaser website, basic components #17

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Dec 23, 2024

Info

localhost_3000_

set up groundwork for routes on the hackathon portal by copying the layout from the teaser website and creating some components that seem to be common across all routes

Changes

  • a1f71d2 copied files from diamondhacks-teaser
  • updated navbar for portal
    • the navbar is not sticky on the hackathon portal so the user can focus on the application
    • missing user name
  • added Card, Heading, and Button components (which seem to be common across pages) so later PRs don't duplicate code or have to depend on another PR for a component
    • the card neutral grey color clashes with the cool blue grey of the background IMO, we probably want to find a different card color that's bluer

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

no

mobile screenshots:

image

image

@SheepTester SheepTester changed the title Copy layout from teaser website, basic components Frontend - Copy layout from teaser website, basic components Dec 23, 2024
Copy link
Collaborator

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Comment on lines +8 to +13
/**
* Unlike `Typography`, the text size for the heading shrinks on mobile.
*/
const Heading = ({ centered, children }: PropsWithChildren<HeadingProps>) => {
return <h1 className={`${styles.heading} ${centered ? styles.centered : ''}`}>{children}</h1>;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I wonder if we can also just have shrinking for Typography as well, I remember doing this for some other repo

https://github.com/acmucsd/outreach-website/tree/main/src/components/Typography

I think this is more of a consideration when we start making a component library so we can have this be standardized

@SheepTester SheepTester merged commit b70e962 into acmucsd:main Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants