Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend admin application reviewing #80

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

echang594
Copy link
Collaborator

@echang594 echang594 commented Feb 3, 2025

Info

Closes #77

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

[description]

Changes

  • New user field for application decision, default no decision
  • New admin routes get and post for that
  • Waitlisted status
  • Migration

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

Post:
Screenshot 2025-02-02 at 5 32 43 PM

Get:
Screenshot 2025-02-02 at 5 33 15 PM

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackathon-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:36am

Copy link

github-actions bot commented Feb 3, 2025

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

Copy link
Collaborator

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's start thinking about a route to publicize application decisions

@echang594 echang594 merged commit 7e3d86d into main Feb 4, 2025
6 checks passed
@echang594 echang594 deleted the backend-admin-application-reviewing branch February 4, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend: Admin Application Reviewing
2 participants