Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multisite generate command. #3614

Merged
merged 4 commits into from
May 6, 2019

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented May 3, 2019

There were a few odd things happening with this command. Mainly, it wasn't setting the local db settings correctly. Also it was setting the remote drush alias as local. Defaults could be set better. Lots of code standards violations.

@danepowell danepowell added 10.x Enhancement A feature or feature request labels May 3, 2019
@danepowell
Copy link
Contributor Author

danepowell commented May 3, 2019

See if we can fix generated local Drush aliases to include a root, pending discussion in #3204.

Actually it looks like there's already code in place to do this if you are running a VM. Maybe it's not working.

@danepowell
Copy link
Contributor Author

danepowell commented May 3, 2019

Bummer... this is now actually blocked by #3204. I think the problem is that we changed the default local alias from self to @foo.local, which wouldn't be a problem except that multisite tests are hitting the bug in #3204.

@greg-1-anderson
Copy link

Workaround: if you are expecting the cwd to be always at the project root, and your Drupal root is always at docroot, then you could set root to ${env.CWD}/docroot for your local aliases. Didn't try it, but should work.

@danepowell
Copy link
Contributor Author

Awesome thanks, I think it's actually ${env.cwd} (lowercase) but that did the trick.

@danepowell danepowell merged commit a296b52 into acquia:10.x May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants