3.3.4 Release

.travis.yml

@@ -45,7 +45,8 @@ matrix:
 
 before_install:
   - git clone --branch ${ORCA_VERSION} --depth 1 https://github.com/acquia/orca.git ../orca
-  - curl https://patch-diff.githubusercontent.com/raw/acquia/orca/pull/31.patch | git -C ../orca apply
+  - curl https://github.com/acquia/orca/commit/278cfe3c1c3bf62c407cc2e5147d266ac3c2dd6c.patch | git -C ../orca apply
+  - curl https://github.com/acquia/orca/commit/2901aa5d9ff0c02cd2ca773fe4ff75f1010e7e37.patch | git -C ../orca apply
   - ../orca/bin/travis/before_install.sh
 
 install:

CHANGELOG.md

@@ -1,3 +1,11 @@
+## 3.3.4
+* Updated Lightning Core to 4.5, which:
+  * Security updated Metatag to 1.9.
+  * Fixed a Drupal Console-related error that could appear even if Drupal Console
+    is not installed. (Issue #3007425)
+  * Sorts module version numbers recorded in the lightning_core.versions config
+    by key. (Issue #3050259)
+
 ## 3.3.3
 * Hotfixed a Composer error caused by erroneous configuration
   shipped with Lightning 3.3.2.

CONTRIBUTING.md

@@ -0,0 +1,24 @@
+## Contributing to Lightning
+
+### Local development
+**Note that these instructions won't work on old, unsupported branches of Lightning.** At the time of this writing, that includes the `8.x-1.x` and `8.x-2.x` branches, which have long since reached the end of their lives.
+
+This documentation describes how to set up Lightning (or any of its components) for development on a machine running a Unix-like operating system (e.g., Linux or macOS). We assume that:
+
+* You have Git installed in your PATH. You can confirm this by running `git --version`.
+* You have PHP 7.1 or later installed in your PATH. You can confirm this by running `php --version`.
+* You have Composer installed in your PATH. You can confirm this by running `composer --version`. You should also have Composer's global binary directory (usually `$HOME/.composer/vendor/bin`) in your PATH.
+* You will need `drush/drush-launcher` globally installed. To confirm this, run `drush --version`. If the command is not found, run `composer global require drush/drush-launcher`.
+* You will also need a database server installed. Lightning uses SQLite by default for development, since it is the most lightweight option supported by Drupal core.
+
+Now, get your Lightning code base set up:
+
+1. Clone the git repository, e.g. `git clone git@github.com:acquia/lightning.git`
+2. Enter the repository and run `composer install` to install all dependencies.
+3. Install Lightning and all necessary components by running `./install-drupal.sh`. By default, this will try to install a SQLite database file called `db.sqlite` in the `docroot` directory. You can override this by passing a `DB_URL` environment variable to `install-drupal.sh`, containing the Drush-compatible URL of the database you want to use. For example:
+
+```
+DB_URL=mysql://user:password@server/drupal ./install-drupal.sh
+```
+4. Run the web server. The quickest option is to use PHP's built-in server: `drush runserver 8080`
+5. You should now be able to access your Lightning site at `http://localhost:8080`.

README.md

@@ -157,28 +157,7 @@ Each Lightning component also has a drupal.org issue queue:
 * [Media](https://www.drupal.org/project/issues/lightning_media)
 * [Workflow](https://www.drupal.org/project/issues/lightning_workflow)
 
-### Local Development
-Lightning has a dev dependency on [Lightning Dev][lightning_dev] which provides
-tools to aid in developing and contributing to Lightning. To install locally:
-
-1. Clone this repo:
-  ```
-  $ git clone git@github.com:acquia/lightning.git
-  ```
-
-1. Install dependencies:
-  ```
-  $ cd lightning
-  $ composer install
-  ```
-
-This will create a fully functional docroot with a git-ignored copy of the
-profile files inside the `docroot/contrib/lightning`. You can modify those files
-directly, then use the provided `composer pull` command to move the changes back
-into the VCS controlled directory.
-
-Lightning is still compatible with PHP 5.6, but you will need PHP >= 7.0.8 in
-order to build a local version of Lightning in this way.
+For more information on local development, see CONTRIBUTING.md.
 
 ### How to uninstall Lightning
 Lightning is an installation profile, so there's no "officially" sanctioned way

composer.json

@@ -8,7 +8,7 @@
         "cweagans/composer-patches": "^1.6.4",
         "drupal-composer/drupal-scaffold": "^2.0.0",
         "drupal/lightning_api": "^4.1",
-        "drupal/lightning_core": "^4.4",
+        "drupal/lightning_core": "^4.5",
         "drupal/lightning_layout": "^1.7",
         "drupal/lightning_media": "^3.8",
         "drupal/lightning_workflow": "^3.6",
@@ -19,6 +19,7 @@
         "drupal/facets": "^1.2",
         "drupal/media_entity_generic": "1.x-dev",
         "drupal/schema_metatag": "^1.3",
+        "drush/drush": "^9.7",
         "webflo/drupal-core-require-dev": "*"
     },
     "config": {