Bump go version #10
Open
Bump go version #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unable to import bind/java: [-: # golang.org/x/mobile/bind/java cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in $PATH]
…3400-ce6a79cf6a13
As per https://stackoverflow.com/a/77686965/901465. Using api 19, our min sdk version.
menduz
reviewed
Jul 8, 2024
| @@ -1,6 +1,7 @@ | |||
| cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
| cloud.google.com/go v0.33.1 h1:fmJQWZ1w9PGkHR1YL/P7HloDvqlmKQ4Vpb7PC2e+aCk= | |||
| cloud.google.com/go v0.33.1/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
| dmitri.shuralyov.com/gpu/mtl v0.0.0-20221208032759-85de2813cf6b/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU= | |||
champo
reviewed
Jul 9, 2024
android/Dockerfile
Outdated
| @@ -13,6 +13,7 @@ RUN apt-get update \ | |||
| curl \ | |||
| git \ | |||
| zip \ | |||
| build-essential\ | |||
There was a problem hiding this comment.
we probably need to find a way to fix the gcc version. this will download "latest" which can differ between runs of the dockerfile and cause non-reproducible builds.
There was a problem hiding this comment.
We believe this is no longer needed, we introduced this to fix a compiling error before trying out the "full"/rebased changes from upstream. Those include a commit where they no longer try to compile certain files before hand. Will try removing this
This reverts commit 725a91e.
Specifically: go get golang.org/x/mobile/cmd/gomobile@v0.0.0-20220414153400-ce6a79cf6a13
Simplifies env setup in other cases (e.g ci toolkit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.