feat: mint + burn routing logic #1864
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinrava
requested review from
mrice32,
nicholaspai,
dohaki,
james-a-morris,
pxrl,
melisaguevara and
amateima
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ashwinrava
changed the base branch from
master
to
mguevara/acx-4479-add-cctp-bridge-strategy
dohaki
reviewed
Sep 30, 2025
| const isLargeDeposit = depositAmountUsd > 1_000_000; // 1M USD | ||
|
|
||
| // Check if eligible for Fast CCTP (Polygon, BSC, Solana) and deposit > 10K USD | ||
| const fastCctpChains = [CHAIN_IDs.POLYGON, CHAIN_IDs.BSC, CHAIN_IDs.SOLANA]; |
There was a problem hiding this comment.
Should this be part of the CCTP bridge strategy?
There was a problem hiding this comment.
Yes, for this use case we are already exporting CCTP_FILL_TIME_ESTIMATES from the strategy. Maybe we can use that combined with a threshold.
There was a problem hiding this comment.
fast CCTP chains can be taken from here. Chains with "seconds" are considered fast
ashwinrava
force-pushed
the
ashwin/acx-4481-implement-acrossnative-routing-logic
branch
from
a8c41f2 to
671465d
Compare
ashwinrava
changed the base branch from
mguevara/acx-4479-add-cctp-bridge-strategy
to
master
ashwinrava
changed the base branch from
master
to
feat/mint-burn-bridge-routing
amateima
reviewed
Oct 1, 2025
Comment on lines
+65
to
+67
| if (bridgeStrategyData.isUtilizationHigh) { | ||
| return getCctpBridgeStrategy(); | ||
| } |
There was a problem hiding this comment.
when utilization is high CCTP strategy should be used only for USDC, right?
|
|
||
| import { CrossSwap, CrossSwapQuotes, Token } from "../_dexes/types"; | ||
| import { AppFee, CrossSwapType } from "../_dexes/utils"; | ||
| import { Logger } from "@across-protocol/sdk/dist/types/relayFeeCalculator"; |
There was a problem hiding this comment.
I see we have some utils in api/_logger.ts. Can we use getLogger from there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the routing logic below. Changes here: a8c41f2
/limitsto return utilization data so that we don't need to refetch itlimitswith a standard amount to maximize cache hits