refactor: Use early return pattern

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
actions · Dec 14, 2022 · 502a50d · 502a50d
1 parent 377c6da
commit 502a50d
Showing 1 changed file with 18 additions and 11 deletions.
diff --git a/src/cache-utils.ts b/src/cache-utils.ts
@@ -61,23 +61,30 @@ const getPackageManagerVersion = async (
 };
 
 export const getPackageManagerInfo = async (packageManager: string) => {
+  if (
+    packageManager !== 'npm' &&
+    packageManager !== 'pnpm' &&
+    packageManager !== 'yarn'
+  ) {
+    return null;
+  }
+
   if (packageManager === 'npm') {
     return supportedPackageManagers.npm;
-  } else if (packageManager === 'pnpm') {
+  }
+
+  if (packageManager === 'pnpm') {
     return supportedPackageManagers.pnpm;
-  } else if (packageManager === 'yarn') {
-    const yarnVersion = await getPackageManagerVersion('yarn', '--version');
+  }
 
-    core.debug(`Consumed yarn version is ${yarnVersion}`);
+  const yarnVersion = await getPackageManagerVersion('yarn', '--version');
+  core.debug(`Consumed yarn version is ${yarnVersion}`);
 
-    if (yarnVersion.startsWith('1.')) {
-      return supportedPackageManagers.yarn1;
-    } else {
-      return supportedPackageManagers.yarn2;
-    }
-  } else {
-    return null;
+  if (yarnVersion.startsWith('1.')) {
+    return supportedPackageManagers.yarn1;
   }
+
+  return supportedPackageManagers.yarn2;
 };
 
 export const getCacheDirectoryPath = async (