Conversation
## Summary of Changes ### src/skills/pr-review.ts Completely refactored the skill with: 1. **New Review Philosophy** - Framed as "Would a senior engineer in a time-limited review raise this?" 2. **Refined Review Priorities** with concrete IS/ISN'T tables: - Correctness: Off-by-one bugs ✓ | Type confusion without runtime impact ✗ - Security: SQL injection ✓ | Hypothetical attack scenarios ✗ - Stability: Race conditions ✓ | Extra defensive checks ✗ - Maintainability: Misleading names ✓ | Naming preferences ✗ 3. **Context from Prior Reviews** section: - Fetches existing PR comments via gh pr view --json comments,reviews - Creates validation todo items for previously-flagged issues - Acknowledges resolved feedback, only flags NEW issues 4. **Common Nitpicks to Avoid** section covering 6 items: - Coding style preferences - Defensive programming suggestions - DRY violations without real cost - Missing code comments - Subjective complexity concerns - Minor refactoring suggestions 5. **Refined Verdict Rules**: - request_changes only for merge-blocking issues - Default severity to low unless clearly higher - Clear severity definitions (medium = "probably causes bug", h Attempt: att-17b28415-95f4-4a5f-b14e-8ca48c414f71 Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
Contributor
AI Review SummaryVerdict: APPROVE FindingsNo significant issues found. Overall AssessmentThis PR significantly improves the pr-review skill by adding clear guidance on what constitutes a real issue versus a nitpick. The changes are well-structured and provide concrete examples that will help the AI focus on substantive problems. The documentation updates align perfectly with the skill changes. |
activadee
deleted the
OW/OW-2-fix-reduce-strictness-in-pr-review-skill-focus-on-real-issues-on
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_changesonly for merge-blocking issues;approveused generously for clean PRs or low-severity findings.