Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize string concatenation using << operator #617

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Optimize string concatenation using << operator #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/arbre/html/tag.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,25 +116,23 @@ def closing_tag
def indent(open_tag, child_content, close_tag)
spaces = ' ' * indent_level * INDENT_SIZE

html = ""
html = +""

if no_child? || child_is_text?
if self_closing_tag?
html += spaces + open_tag.sub( />$/, '/>' )
html << spaces << open_tag.sub( />$/, '/>' )
else
# one line
html += spaces + open_tag + child_content + close_tag
html << spaces << open_tag << child_content << close_tag
end
else
# multiple lines
html += spaces + open_tag + "\n"
html += child_content # the child takes care of its own spaces
html += spaces + close_tag
html << spaces << open_tag << "\n"
html << child_content # the child takes care of its own spaces
html << spaces << close_tag
end

html += "\n"

html
html << "\n"
end

def self_closing_tag?
Expand Down