-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PIVOT-6998 Fix ratio measures (#111)
* Fix ratio measures * Remove commented line * Add tests * Formatting * Fix COMMITTED_CHUNK_MEMORY measure definition * Fix formatting * Sort imports --------- Co-authored-by: MehdiEnnaime <45753632+MehdiEnnaime@users.noreply.github.com>
- Loading branch information
1 parent
b0d6d46
commit 4d50f40
Showing
2 changed files
with
176 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
163 changes: 163 additions & 0 deletions
163
src/test/java/com/activeviam/mac/statistic/memory/TestRatioMeasures.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| package com.activeviam.mac.statistic.memory; | ||
|
|
||
| import com.activeviam.mac.cfg.impl.ManagerDescriptionConfig; | ||
| import com.activeviam.mac.memory.MemoryAnalysisDatastoreDescriptionConfig; | ||
| import com.activeviam.pivot.utils.ApplicationInTests; | ||
| import com.qfs.monitoring.statistic.memory.IMemoryStatistic; | ||
| import com.qfs.pivot.monitoring.impl.MemoryAnalysisService; | ||
| import com.qfs.server.cfg.IDatastoreSchemaDescriptionConfig; | ||
| import com.qfs.store.IDatastore; | ||
| import com.quartetfs.biz.pivot.IMultiVersionActivePivot; | ||
| import com.quartetfs.biz.pivot.dto.CellSetDTO; | ||
| import com.quartetfs.biz.pivot.query.impl.MDXQuery; | ||
| import com.quartetfs.fwk.AgentException; | ||
| import com.quartetfs.fwk.Registry; | ||
| import com.quartetfs.fwk.contributions.impl.ClasspathContributionProvider; | ||
| import com.quartetfs.fwk.query.QueryException; | ||
| import java.nio.file.Path; | ||
| import java.util.List; | ||
| import java.util.stream.IntStream; | ||
| import org.assertj.core.api.Assertions; | ||
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestRatioMeasures extends ATestMemoryStatistic { | ||
|
|
||
| public static final int ADDED_DATA_SIZE = 20; | ||
| private ApplicationInTests<IDatastore> monitoredApp; | ||
| private ApplicationInTests<IDatastore> monitoringApp; | ||
|
|
||
| @BeforeAll | ||
| public static void setupRegistry() { | ||
| Registry.setContributionProvider(new ClasspathContributionProvider()); | ||
| } | ||
|
|
||
| @BeforeEach | ||
| public void setup() throws AgentException { | ||
| this.monitoredApp = createMicroApplicationWithIsolatedStoreAndKeepAllEpochPolicy(); | ||
|
|
||
| this.monitoredApp | ||
| .getDatabase() | ||
| .edit( | ||
| tm -> | ||
| IntStream.range(0, ADDED_DATA_SIZE) | ||
| .forEach( | ||
| i -> { | ||
| tm.add("A", i, i / 10D); | ||
| tm.add("B", i, i / 10D); | ||
| })); | ||
|
|
||
| // Force to discard all versions | ||
| this.monitoredApp.getDatabase().getEpochManager().forceDiscardEpochs(__ -> true); | ||
|
|
||
| // perform GCs before exporting the store data | ||
| performGC(); | ||
| final MemoryAnalysisService analysisService = | ||
| (MemoryAnalysisService) | ||
| createService(this.monitoredApp.getDatabase(), this.monitoredApp.getManager()); | ||
| final Path exportPath = analysisService.exportMostRecentVersion("testOverview"); | ||
|
|
||
| final IMemoryStatistic stats = loadMemoryStatFromFolder(exportPath); | ||
|
|
||
| // Start a monitoring datastore with the exported data | ||
| final ManagerDescriptionConfig config = new ManagerDescriptionConfig(); | ||
| final IDatastoreSchemaDescriptionConfig schemaConfig = | ||
| new MemoryAnalysisDatastoreDescriptionConfig(); | ||
|
|
||
| this.monitoringApp = | ||
| ApplicationInTests.builder() | ||
| .withDatastore(schemaConfig.datastoreSchemaDescription()) | ||
| .withManager(config.managerDescription()) | ||
| .build(); | ||
|
|
||
| resources.register(this.monitoringApp).start(); | ||
|
|
||
| // Fill the monitoring datastore | ||
| ATestMemoryStatistic.feedMonitoringApplication( | ||
| monitoringApp.getDatabase(), List.of(stats), "storeA"); | ||
|
|
||
| final IMultiVersionActivePivot pivot = | ||
| this.monitoringApp | ||
| .getManager() | ||
| .getActivePivots() | ||
| .get(ManagerDescriptionConfig.MONITORING_CUBE); | ||
| Assertions.assertThat(pivot).isNotNull(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDirectMemoryRatio() throws QueryException { | ||
| final IMultiVersionActivePivot pivot = | ||
| this.monitoringApp | ||
| .getManager() | ||
| .getActivePivots() | ||
| .get(ManagerDescriptionConfig.MONITORING_CUBE); | ||
|
|
||
| final MDXQuery totalDirectMemory = | ||
| new MDXQuery( | ||
| "SELECT NON EMPTY [Measures].[DirectMemory.SUM] ON COLUMNS " | ||
| + "FROM [MemoryCube]" | ||
| + "WHERE [Owners].[Owner].[ALL].[AllMember]"); | ||
|
|
||
| final MDXQuery storeADirectMemory = | ||
| new MDXQuery( | ||
| "SELECT NON EMPTY [Measures].[DirectMemory.SUM] ON COLUMNS " | ||
| + "FROM [MemoryCube]" | ||
| + "WHERE [Owners].[Owner].[ALL].[AllMember].[Store A]"); | ||
|
|
||
| final MDXQuery storeADirectMemoryRatio = | ||
| new MDXQuery( | ||
| "SELECT NON EMPTY [Measures].[DirectMemory.Ratio] ON COLUMNS " | ||
| + "FROM [MemoryCube]" | ||
| + "WHERE [Owners].[Owner].[ALL].[AllMember].[Store A]"); | ||
|
|
||
| final CellSetDTO total = pivot.execute(totalDirectMemory); | ||
| final CellSetDTO storeA = pivot.execute(storeADirectMemory); | ||
| final CellSetDTO ratio = pivot.execute(storeADirectMemoryRatio); | ||
|
|
||
| Assertions.assertThat(CellSetUtils.extractDoubleValueFromSingleCellDTO(ratio).doubleValue()) | ||
| .isEqualTo(0.5D); | ||
| Assertions.assertThat(CellSetUtils.extractDoubleValueFromSingleCellDTO(ratio).doubleValue()) | ||
| .isEqualTo( | ||
| CellSetUtils.extractValueFromSingleCellDTO(storeA) | ||
| / CellSetUtils.extractValueFromSingleCellDTO(total).doubleValue()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCommittedRowsRatio() throws QueryException { | ||
| final IMultiVersionActivePivot pivot = | ||
| this.monitoringApp | ||
| .getManager() | ||
| .getActivePivots() | ||
| .get(ManagerDescriptionConfig.MONITORING_CUBE); | ||
|
|
||
| final MDXQuery storeAcommittedRows = | ||
| new MDXQuery( | ||
| "SELECT NON EMPTY [Measures].[CommittedRows.COUNT] ON COLUMNS " | ||
| + "FROM [MemoryCube]" | ||
| + "WHERE [Owners].[Owner].[ALL].[AllMember].[Store A]"); | ||
|
|
||
| final MDXQuery storeAchunkSize = | ||
| new MDXQuery( | ||
| "SELECT NON EMPTY [Measures].[ChunkSize.SUM] ON COLUMNS " | ||
| + "FROM [MemoryCube]" | ||
| + "WHERE [Owners].[Owner].[ALL].[AllMember].[Store A]"); | ||
|
|
||
| final MDXQuery storeAcommittedRowsRatio = | ||
| new MDXQuery( | ||
| "SELECT NON EMPTY [Measures].[CommittedRows.Ratio] ON COLUMNS " | ||
| + "FROM [MemoryCube]" | ||
| + "WHERE [Owners].[Owner].[ALL].[AllMember].[Store A]"); | ||
|
|
||
| final CellSetDTO committedRows = pivot.execute(storeAcommittedRows); | ||
| final CellSetDTO chunkSize = pivot.execute(storeAchunkSize); | ||
| final CellSetDTO ratio = pivot.execute(storeAcommittedRowsRatio); | ||
|
|
||
| Assertions.assertThat(CellSetUtils.extractDoubleValueFromSingleCellDTO(ratio).doubleValue()) | ||
| .isNotIn(0D, 1D); | ||
| Assertions.assertThat(CellSetUtils.extractDoubleValueFromSingleCellDTO(ratio).doubleValue()) | ||
| .isEqualTo( | ||
| CellSetUtils.extractValueFromSingleCellDTO(committedRows) | ||
| / CellSetUtils.extractValueFromSingleCellDTO(chunkSize).doubleValue()); | ||
| } | ||
| } |