Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alpaka version for improved HIP support + HIP updates #519

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

StewMH
Copy link
Contributor

@StewMH StewMH commented Feb 13, 2024

Update the Alpaka version and add ifdefs etc to allow Alpaka to work with vecmem_hip. Needs a new vecmem version with acts-project/vecmem#272 before it can be merged.

@StewMH StewMH changed the title Update Alpaka version for improved HIP support Update Alpaka version for improved HIP support + HIP updates Mar 7, 2024
@StewMH
Copy link
Contributor Author

StewMH commented Apr 11, 2024

@krasznaa could we have a vecmem 1.4.1 soon for this? Unless there are pending vecmem developments I'm not aware of.

@krasznaa
Copy link
Member

@krasznaa could we have a vecmem 1.4.1 soon for this? Unless there are pending vecmem developments I'm not aware of.

It's good that you pinged me. Here is the new tag:

https://github.com/acts-project/vecmem/releases/tag/v1.5.0

@StewMH StewMH marked this pull request as ready for review April 11, 2024 13:30
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Just once again, let's merge it with a squash if possible. 😉

@beomki-yeo beomki-yeo merged commit 2d28a87 into acts-project:main Apr 17, 2024
17 of 18 checks passed
@StewMH StewMH deleted the new_alpaka_version branch April 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants