Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An optimization for LANGMATCHES #1623

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+87 −20

Merge branch 'master' into add-langmatches-triples

60adbeb
Select commit
Loading
Failed to load commit list.
Open

An optimization for LANGMATCHES #1623

Merge branch 'master' into add-langmatches-triples
60adbeb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 9, 2025 in 0s

89.77% (-0.10%) compared to acb6633

View this Pull Request on Codecov

89.77% (-0.10%) compared to acb6633

Details

Codecov Report

Attention: Patch coverage is 48.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (acb6633) to head (60adbeb).

Files with missing lines Patch % Lines
src/engine/sparqlExpressions/StringExpressions.cpp 0.00% 12 Missing ⚠️
src/parser/ParsedQuery.cpp 38.46% 5 Missing and 3 partials ⚠️
src/parser/sparqlParser/SparqlQleverVisitor.cpp 40.00% 2 Missing and 1 partial ⚠️
src/util/Conversions.cpp 78.57% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
- Coverage   89.86%   89.77%   -0.10%     
==========================================
  Files         389      389              
  Lines       37308    37347      +39     
  Branches     4204     4209       +5     
==========================================
+ Hits        33527    33528       +1     
- Misses       2485     2507      +22     
- Partials     1296     1312      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov