Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Store HTTP Protocol (GET, POST) back end #1668

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Dec 8, 2024

Implement a function transformGraphStoreProtocol that does the back end of transforming a SPARQL Graph Store HTTP Protocol request to it's equivalent SPARQL Query or Update. The integration will be a separate step.

TODO:

  • think about function definition in header

Additional smaller changes that were required or sensible and which could be extracted into separate PRs if needed:

  • move checkParameter from Server to ad_utility::url_parser
  • extract creation of test HTTP request into HttpRequestHelper
  • add methods to access Id from TripleComponent
  • added media types N-Triples and N-Quads

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 96.36364% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (a97905e) to head (ec03ba1).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/GraphStoreProtocol.h 94.23% 2 Missing and 1 partial ⚠️
src/engine/Server.cpp 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   89.86%   89.89%   +0.03%     
==========================================
  Files         389      392       +3     
  Lines       37189    37460     +271     
  Branches     4196     4221      +25     
==========================================
+ Hits        33419    33676     +257     
- Misses       2473     2484      +11     
- Partials     1297     1300       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qup42 Qup42 marked this pull request as ready for review December 16, 2024 11:29
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first round of reviews, this is already looking very promising.

src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/engine/GraphStoreProtocol.h Outdated Show resolved Hide resolved
src/parser/TripleComponent.h Outdated Show resolved Hide resolved
test/util/HttpRequestHelpers.h Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
test/GraphStoreProtocolTest.cpp Outdated Show resolved Hide resolved
@sparql-conformance
Copy link

Copy link

sonarqubecloud bot commented Jan 9, 2025

@Qup42 Qup42 requested a review from joka921 January 10, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants