Add macros QL_CONCEPT_OR_NOTHING and QL_CONCEPT_OR_TEMPLATE
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17 backports. Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/util/TypeTraits.h
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
- Coverage 89.87% 89.84% -0.03%
==========================================
Files 389 389
Lines 37268 37268
Branches 4202 4202
==========================================
- Hits 33493 33485 -8
- Misses 2478 2482 +4
- Partials 1297 1301 +4 ☔ View full report in Codecov by Sentry. |
hannahbast
requested changes
Dec 17, 2024
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
hannahbast
approved these changes
Dec 17, 2024
hannahbast
changed the title
SameAsAny concept to C++17QL_CONCEPT_OR_NOTHING and QL_CONCEPT_OR_TEMPLATE
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two macros can be used for concepts that improve the semantics and safety of the code, but are not necessary for compilation. They can be dropped or replaced by something simpler when compiling with C++17.
The macro
QL_CONCEPT_OR_NOTHINGcan be used for concepts that can be omitted when compiling with C++17. For example,QL_CONCEPT_OR_NOTHING(std::view) auto x = someFunction().The macro
QL_CONCEPT_OR_TEMPLATEcan be used for concepts that can be replaced bytypenamewhen compiling with C++17. For example,template <QL_CONCEPT_OR_TYPENAME(ql::same_as<int>) T> void f(){...}.