Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outsourcing and improving the posting writing of IndexImpl.Text.cpp #1699

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Implemented the small changes requested. (Using ql::views and lowerca…

777329a
Select commit
Loading
Failed to load commit list.
Open

Outsourcing and improving the posting writing of IndexImpl.Text.cpp #1699

Implemented the small changes requested. (Using ql::views and lowerca…
777329a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

89.86% (-0.01%) compared to acb6633, passed because coverage increased by 0.03% when compared to adjusted base (89.83%)

View this Pull Request on Codecov

89.86% (-0.01%) compared to acb6633, passed because coverage increased by 0.03% when compared to adjusted base (89.83%)

Details

Codecov Report

Attention: Patch coverage is 93.01310% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (acb6633) to head (777329a).

Files with missing lines Patch % Lines
src/index/TextIndexReadWrite.cpp 91.52% 6 Missing and 4 partials ⚠️
src/index/TextIndexReadWrite.h 90.62% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   89.86%   89.86%   -0.01%     
==========================================
  Files         389      391       +2     
  Lines       37308    37317       +9     
  Branches     4204     4203       -1     
==========================================
+ Hits        33527    33535       +8     
- Misses       2485     2487       +2     
+ Partials     1296     1295       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.