Fix the cost estimate of the Spatial Join operation
#1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cost estimate didn't include the cost of the children previously. This bug led to non-sense output in the runtime information JSON output in some cases, because the RuntimeInformation::getOperationCostEstimate subtracted child cost estimates that were larger than the spatial join cost. The resulting negative number interpreted as size_t (unsigned) caused an output near 2**64. This is now fixed by adding the child cost to the spatial join cost estimate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1700 +/- ##
=======================================
Coverage 89.85% 89.86%
=======================================
Files 389 389
Lines 37287 37288 +1
Branches 4204 4204
=======================================
+ Hits 33505 33507 +2
+ Misses 2483 2478 -5
- Partials 1299 1303 +4 ☔ View full report in Codecov by Sentry. |
joka921
requested changes
Jan 8, 2025
Conformance check passed ✅No test result changes. |
|
joka921
approved these changes
Jan 8, 2025
joka921
changed the title
Spatial Join operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cost estimate of the
SpatialJoinclass didn't account for the cost of computing the children. This is now fixed.