simplify process methods in url pattern #999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/simplify-process-methods
branch
from
293cc51 to
911abb3
Compare
anonrig
force-pushed
the
yagiz/simplify-process-methods
branch
from
d8610d8 to
2a4a265
Compare
lemire
reviewed
Sep 24, 2025
| } | ||
| return std::string(value); | ||
| } | ||
| // Return the result of running canonicalize a protocol given strippedValue. |
There was a problem hiding this comment.
Maybe we could add as a comment that canonicalize_protocol will already remove the trailing : if any ? (optional)
lemire
reviewed
Sep 24, 2025
| // Return the result of running canonicalize a search given strippedValue. | ||
| return url_pattern_helpers::canonicalize_search(value); | ||
| } | ||
|
|
There was a problem hiding this comment.
If type != process_type::pattern, then you are no longer removing an eventual ?. But I don't see canonicalize_search doing the check. So it looks like you might have made a change in the logic?
lemire
reviewed
Sep 24, 2025
| } | ||
| return std::string(value); | ||
| } | ||
| // Return the result of running canonicalize a hash given strippedValue. |
There was a problem hiding this comment.
I have the same question here... you might now pass a leading # to canonicalize_hash whereas you use not to. Why is this ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we don't need to remove the first character in happy path.