Домашнее задание 12.2. Double под микроскопом. Разгуляева А.И. #11
Open
Домашнее задание 12.2. Double под микроскопом. Разгуляева А.И. #11
Conversation
Collaborator
p-senichenkov
left a comment
p-senichenkov
left a comment
There was a problem hiding this comment.
Нет тестов, CMake и CI.
| char decimal_digits[21]; // массив для хранения 20 цифр + 1 для округления | ||
| int digit_count = 0; | ||
|
|
||
| // генерируем 21 цифру (20 для вывода + 1 для округления) |
Collaborator
There was a problem hiding this comment.
Почему именно 20 цифр? IEEE754 double хранит 53 значащих бита. Именно столько и нужно сохранять.
| } DoubleConverter; | ||
|
|
||
| // преобразование double в экспоненциальный формат (sm*2^p) | ||
| char* doubleExponential(double number) |
Collaborator
There was a problem hiding this comment.
Выделите отдельные функции. Не должна одна функция занимать полтора экрана.
Comment on lines
+89
to
+100
| // удаляем незначащие нули с конца | ||
| while (digit_count > 0 && decimal_digits[digit_count - 1] == '0') { | ||
| digit_count--; | ||
| } | ||
|
|
||
| // выводим дробную часть, если есть значащие цифры | ||
| if (digit_count > 0) { | ||
| result[pos++] = '.'; | ||
| for (int i = 0; i < digit_count; i++) { | ||
| result[pos++] = decimal_digits[i]; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Здесь уже совсем что-то не то делается.
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.