Conversation
p-senichenkov
approved these changes
Dec 11, 2025
Collaborator
p-senichenkov
left a comment
p-senichenkov
left a comment
There was a problem hiding this comment.
Палиндром: 18/20
Циклический сдвиг: 11/10
Comment on lines
+165
to
+167
| while (scanf("%d", &number) == 1 && number > 0) { | ||
| head = append(head, number); | ||
| } |
Collaborator
There was a problem hiding this comment.
Этот while имеет квадратичную сложность, хотя сам алгоритм линейный. А можно сделать это за O(n), если где-то сохранить указатель на последний элемент списка.
| @@ -0,0 +1,40 @@ | |||
| #ifndef PALINDROM_H | |||
Collaborator
There was a problem hiding this comment.
По стайлгайду мы не используем include guards.
| Node* createListFromArray(int arr[], int n); | ||
|
|
||
| // тест с несимметричным списком | ||
| void test1(); |
Collaborator
There was a problem hiding this comment.
Тесты лучше выделить в отдельный файл.
| @@ -0,0 +1,29 @@ | |||
| #include <stdio.h> | |||
|
|
|||
| int main() | |||
Collaborator
There was a problem hiding this comment.
Лучше не писать всё в main. Хотя бы потому, что у Вас не получится сделать юнит-тесты.
| // собираем число с позиции start | ||
| for (int i = 0; i < N; i++) { | ||
| int idx = (start + i) % N; | ||
| current = (current << 1) | bits[idx]; // добавляем бит |
Collaborator
There was a problem hiding this comment.
+2 балла за использование битовых операций (+5 я ставил только если циклический сдвиг тоже сделать на битовых операциях)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.