Open
Conversation
Godrik0
suggested changes
Dec 3, 2025
|
|
||
| return arr | ||
|
|
||
| # |
There was a problem hiding this comment.
Чтобы не комментировать такие вещи, оборачивайте то, что должно запускаться только при запуске непосредственно самого файла, в if __name__ == "__main__".
Comment on lines
+100
to
+116
| def test_heap_sort_builtin(): | ||
| """Сравнение с встроенной сортировкой""" | ||
| n = [1, 2, 10, 1, 100] | ||
| assert heap_sort(n) == sorted(n) | ||
|
|
||
|
|
||
| def test_compare_with_bubble_sort(): | ||
| """Сравнение с пузырьковой сортировкой""" | ||
| n = [1, 2, 10, 1, 100] | ||
|
|
||
| assert heap_sort(n) == bubble_sort(n) | ||
|
|
||
|
|
||
| def test_compare_with_selection_sort(): | ||
| """Сравнение с сортировкой выбором""" | ||
| n = [1, 2, 10, 1, 100] | ||
| assert heap_sort(n) == selection_sort(n) |
There was a problem hiding this comment.
Нужно использовать .copy() так как вы передаете один и тот же массив.
| n = len(arr) | ||
|
|
||
| # строим max-heap | ||
| for i in range(n, -1, -1): |
There was a problem hiding this comment.
Нет смысла начинать с n, эффективнее начинать с последнего родительского узла n // 2 - 1.
Comment on lines
+97
to
+116
| """Сравнение с другими сортировками""" | ||
|
|
||
|
|
||
| def test_heap_sort_builtin(): | ||
| """Сравнение с встроенной сортировкой""" | ||
| n = [1, 2, 10, 1, 100] | ||
| assert heap_sort(n) == sorted(n) | ||
|
|
||
|
|
||
| def test_compare_with_bubble_sort(): | ||
| """Сравнение с пузырьковой сортировкой""" | ||
| n = [1, 2, 10, 1, 100] | ||
|
|
||
| assert heap_sort(n) == bubble_sort(n) | ||
|
|
||
|
|
||
| def test_compare_with_selection_sort(): | ||
| """Сравнение с сортировкой выбором""" | ||
| n = [1, 2, 10, 1, 100] | ||
| assert heap_sort(n) == selection_sort(n) |
There was a problem hiding this comment.
Для property based тестов нужно тоже генерировать массивы и сравнивать на них сортировки.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.