Misc fixes. #46
Misc fixes. #46
Conversation
Adafruit_Thermal.cpp
Outdated
| while (digitalRead(dtrPin) == HIGH) | ||
| ; | ||
| while (digitalRead(dtrPin) == HIGH) { | ||
| delay(0); |
There was a problem hiding this comment.
can you make these delay(1) or yield()?
There was a problem hiding this comment.
Sure, can bump up value. Was avoiding yield() based on this comment:
#26 (comment)
Idea being that ESP8266's delay() calls yield() under the hood. Hopefully using delay() is more universal.
There was a problem hiding this comment.
yield is most like delay(0), delay(1) of course delays. ill say i use yield() in libraries and never heard a complaint
There was a problem hiding this comment.
it may be old lore? all the BSPs have caught up now? yield makes more sense than delay, was just wanting to avoid preprocessor logic if possible.
There was a problem hiding this comment.
yeah all BSPs have caught up, that was 4 years ago :D
|
ESP8266 testing for the record. Previously it would WDT timeout on the bitmap print.
|
A couple of fixes here.
delay(0)in the loop to allow ESP8266's implementation to yield as needed. This way don't need any pre-processor logic.DC2 *inbegin(). Moved that configuration to a new functionsetPrintDensity()and then don't call it by default. Resulting prints look fine without it.Here's an example WDT reset just for records:
