Added support for setting data rate #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves #12 |
|
I wouldn't encourage use of |
|
@tannewt Ok, I'll give that a go |
ladyada
approved these changes
Jun 28, 2020
|
@tannewt Ok, I allowed you to set the data rate when initializing it. I decided not to add a function to do that after initialization since the range was being set upon initialization as well. |
evaherrada
changed the title
tannewt
requested changes
Jun 29, 2020
adafruit_l3gd20.py
Outdated
Comment on lines
130
to
131
| # self.write_register(_L3GD20_REGISTER_CTRL_REG1, 0x0F) | ||
| self.write_register(_L3GD20_REGISTER_CTRL_REG1, rate + 0x0F) |
There was a problem hiding this comment.
Suggested change
| # self.write_register(_L3GD20_REGISTER_CTRL_REG1, 0x0F) | |
| self.write_register(_L3GD20_REGISTER_CTRL_REG1, rate + 0x0F) | |
| self.write_register(_L3GD20_REGISTER_CTRL_REG1, rate | 0x0F) |
adafruit_l3gd20.py
Outdated
| spi_busio, | ||
| cs, | ||
| rng=L3DS20_RANGE_250DPS, | ||
| rate=L3DS20_RATE_100HZ, |
There was a problem hiding this comment.
Add rate after baudrate to prevent breaking code that relies on position of these args. It wouldn't matter if there was a *, before the kwargs to make them kwarg-only.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 3, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.0.1 from 1.0.0: > Update README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.3.0 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#19 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.7.6 from 2.7.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#57 from FoamyGuy/fix_anchor_when_text_is_scaled
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with a feather M0 running CircuitPython 5.3.0