Skip to content

Fix ArduinoISP.ino word-based address for reading/writing EEPROM #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix ArduinoISP.ino word-based address for reading/writing EEPROM #2188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97e4680
Fix word-based addressing for dumping EEPROM content
x0urc3 Jun 15, 2022
2d8882b
Wrong operator
x0urc3 Jun 15, 2022
95e99f2
Fix word-based addressing for writing EEPROM
x0urc3 Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ArduinoISP/ArduinoISP/ArduinoISP.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,17 +488,20 @@ byte write_eeprom(int length) {
// here is a word address, so we use here*2
// this writes byte-by-byte,
// page writing may be faster (4 bytes at a time)
int start = _addr*2;
for (int x = 0; x < length; x++) {
spi_transaction(0xC0, 0x00, _addr*2+x, buff[x]);
int addr = start + x;
spi_transaction(0xC0, (addr >> 8) & 0xFF, addr & 0xFF, buff[x]);
delay(45);
}
return STK_OK;
}

void program_page() {
byte result = STK_FAILED;
int length = 256 * getch() + getch();
if (length > 256) {
unsigned int length = 256 * getch();
length += getch();
if (length > param.eepromsize) {
Serial.write(STK_FAILED);
error++;
return;
Expand Down Expand Up @@ -549,8 +552,10 @@ char flash_read_page(int length) {

char eeprom_read_page(int length) {
// here again we have a word address
int start = _addr*2;
for (int x = 0; x < length; x++) {
byte ee = spi_transaction(0xA0, 0x00, _addr*2+x, 0xFF);
int addr = start +x;
byte ee = spi_transaction(0xA0, (addr >> 8) & 0xFF, addr & 0xFF, 0xFF);
Serial.write( ee);
}
return STK_OK;
Expand Down