new float volume setting and don't set volume to override #3121
+15
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
I think this is good to go.
I pushed a commit to update the usage inside of spell jam app as well. I believe that is the only other current usage of the API in learn projects.
This should get merged at the same time as these once they've been reviewed:
adafruit/Adafruit_CircuitPython_FruitJam#22
adafruit/Fruit-Jam-OS#71
This was referenced Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FoamyGuy
This updates the default volume settings to the float 0.0-1.0 range and restricts the "volume_override_danger" parameter to setting only the safe_volume_limit and not directly impacting the volume setting.
I'm marking this as draft as the merge should be coordinated with other apps and library PRs including adafruit/Adafruit_CircuitPython_FruitJam#22