-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto sensitivity #35
Open
s-light
wants to merge
53
commits into
adafruit:master
Choose a base branch
from
s-light:auto_sensitivity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Auto sensitivity #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(allows for local builds..)
(to better test actual library behavior)
+ expand example
(& cleanup examples)
(and do not use std:min & std:max)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-Request adds a new way of configuration management to the Adafruit_TSL2561 core files.
they enable a advanced & fast configuration setting.
this functionality is used in the
slight_TSL2591AutoSensitivity
class.(currently located in the example
tsl2591_auto_sensitivity
)This class implements a automatic switching of the configuration to get the full range of light sensitivity the sensor offers.
i think this class gives a big useful addition for the sensor - as you don't have to think about the correct sensitivity range anymore.
additionally i have added a simple average filter.
one more idea is a 'value has changed flag' -
that is aware of the current 'range':
for 0.1..2 Lux it triggers if first first decimal place changes
for 2..10 lux it triggers if first integral digit changes (but does not on fractional changes)
and so on...
this way 'noise' does not trigger...
if Adafruit is willing to merge this, i am happy to rename this class..
if this 'auto sensitivity' is to 'advanced' / not matching for this lib i will split this functionality into my own library.
and would add a advanced example explaining the use of the advanced configuration here.
please let me know what you think of this!
sunny greetings
stefan