Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rp2350 pio2 by using sdk pio_get_instance & PIO_IRQ_NUM #2

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

jepler
Copy link
Member

@jepler jepler commented Jan 26, 2025

Before this change, only pio0/1 was usable for USB Host.

I'll also PR this upstream.

@jepler jepler force-pushed the support-rp2350-pio2 branch 2 times, most recently from 6fd9478 to 21b0b3e Compare January 26, 2025 17:06
@dhalbert
Copy link

Is this what is already in adafruit/circuitpython#9999 ?

@jepler
Copy link
Member Author

jepler commented Jan 28, 2025

@jepler
Copy link
Member Author

jepler commented Jan 28, 2025

hmmm it may not match...

@jepler
Copy link
Member Author

jepler commented Jan 28, 2025

circuitpython main branch is at b559b3e. This pull includes that ref but ads 7f7ea5b which fixes the CI for old pico-sdk versions.

once this is merged it wouldn't hurt to bump CircuitPython to match the tip of adafruit/Pico-PIO-USB but for our purposes it's no functional difference.

Copy link

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! Go ahead and submit a simple PR to update circuitpython to the merge commit here.

@dhalbert dhalbert merged commit b004a76 into main Jan 28, 2025
12 checks passed
@dhalbert dhalbert deleted the support-rp2350-pio2 branch January 28, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants