Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): fix docker healthcheck. #416

Merged
merged 2 commits into from
May 13, 2024
Merged

feat(db): fix docker healthcheck. #416

merged 2 commits into from
May 13, 2024

Conversation

AHPanna
Copy link
Contributor

@AHPanna AHPanna commented May 13, 2024

While running the test db for docker mysql, it crashed on the health check, just adding the docker compose health check parameters using the best practice mysql health check methods (ping) : https://dev.mysql.com/doc/refman/8.0/en/mysqladmin.html

@AHPanna AHPanna requested a review from wdavidw May 13, 2024 14:03
@wdavidw
Copy link
Member

wdavidw commented May 13, 2024

Excellent, thank you @AHPanna

@wdavidw wdavidw merged commit 6ce7379 into master May 13, 2024
14 of 17 checks passed
@wdavidw wdavidw deleted the feat/fix-db-test-env branch May 13, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants