p2p: gives seednode priority over dnsseed if both are provided #11

adamjonas · 2024-03-24T15:14:33Z

This is a follow-up of #27577

If both seednode and dnsseed are provided, the node will start a race between them in order to fetch data to feed the addrman.

This PR gives priority to seednode over dnsseed so if some nodes are provided as seeds, they can be tried before defaulting to the dnsseeds

fresheyes-staging-bot · 2024-03-24T15:14:36Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1614729128 at 2023/06/30, 14:23:13 UTC.

fresheyes-staging-bot · 2024-03-24T15:14:39Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1614740856 at 2023/06/30, 14:31:07 UTC.

fresheyes-staging-bot · 2024-03-24T15:14:42Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1247939565 at 2023/06/30, 14:33:26 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1507314838 at 2023/06/30, 14:33:31 UTC.

fresheyes-staging-bot · 2024-03-24T15:14:48Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1248003587 at 2023/06/30, 15:32:53 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1507426180 at 2023/06/30, 15:32:53 UTC.

fresheyes-staging-bot · 2024-03-24T15:14:54Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1620432636 at 2023/07/04, 15:17:04 UTC.

fresheyes-staging-bot · 2024-03-24T15:14:57Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1719715935 at 2023/09/14, 15:51:01 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:00Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1721636751 at 2023/09/15, 17:47:29 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:03Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1721675839 at 2023/09/15, 18:23:36 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:06Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1915660249 at 2024/01/29, 22:07:41 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:09Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1500860485 at 2024/02/23, 15:54:24 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1898431958 at 2024/02/23, 15:55:48 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:15Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1506680713 at 2024/02/28, 21:21:45 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1907452770 at 2024/02/28, 21:21:45 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:21Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1969943448 at 2024/02/28, 21:22:55 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:24Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1507284771 at 2024/02/29, 09:38:55 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:27Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1971075082 at 2024/02/29, 12:51:19 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:30Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1507551723 at 2024/02/29, 13:10:58 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:33Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1971286932 at 2024/02/29, 14:40:11 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:36Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1971591320 at 2024/02/29, 17:11:26 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:39Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1971613276 at 2024/02/29, 17:24:26 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:42Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1509988505 at 2024/03/02, 14:55:51 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:45Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1974932810 at 2024/03/02, 22:58:39 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1908397309 at 2024/03/03, 21:54:06 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:51Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1510418552 at 2024/03/03, 22:49:45 UTC.

fresheyes-staging-bot

An author reviewed and approved here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1913140932 at 2024/03/03, 22:56:14 UTC.

fresheyes-staging-bot · 2024-03-24T15:15:57Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1984448937 at 2024/03/07, 20:58:50 UTC.

fresheyes-staging-bot

An author reviewed and approved here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1928238964 at 2024/03/11, 15:56:45 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:03Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1989319006 at 2024/03/11, 19:55:47 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1932896265 at 2024/03/12, 22:50:22 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:09Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-1997145016 at 2024/03/14, 10:41:35 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:12Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1526788396 at 2024/03/15, 20:13:50 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1940456720 at 2024/03/15, 20:13:50 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:18Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1526840921 at 2024/03/15, 21:07:03 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1940623925 at 2024/03/15, 21:07:03 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:24Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-2000573613 at 2024/03/15, 22:14:42 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:27Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-2004240467 at 2024/03/18, 15:36:39 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:30Z

This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1528799665 at 2024/03/18, 15:38:27 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1943457030 at 2024/03/18, 15:38:28 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:36Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-2004255723 at 2024/03/18, 15:40:16 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:39Z

src/net.cpp

@@ -2185,11 +2185,36 @@ void CConnman::WakeMessageHandler()

 void CConnman::ThreadDNSAddressSeed()
 {
+    constexpr int TARGET_OUTBOUND_CONNECTIONS = 2;


2 authors commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1529316003 at 2024/03/18, 21:36:04 UTC

comment link https://github.com/bitcoin/bitcoin/pull/28016#discussion_r1530559573 at 2024/03/19, 14:58:56 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1944254499 at 2024/03/18, 21:36:05 UTC.

fresheyes-staging-bot

An author reviewed and commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#pullrequestreview-1946525730 at 2024/03/19, 14:58:56 UTC.

fresheyes-staging-bot · 2024-03-24T15:16:48Z

An author commented here with:

comment link https://github.com/bitcoin/bitcoin/pull/28016#issuecomment-2016551125 at 2024/03/23, 17:13:52 UTC.

sr-gi and others added 2 commits February 2, 2024 11:54

Gives seednode priority over dnsseed if both are provided

206094a

Added seednode prioritization message to help output

2842e51

fresheyes-staging-bot bot reviewed Mar 24, 2024

View reviewed changes

fresheyes-staging-bot bot approved these changes Mar 24, 2024

View reviewed changes

fresheyes-staging-bot bot reviewed Mar 24, 2024

View reviewed changes

p2p: gives seednode priority over dnsseed if both are provided #11

Are you sure you want to change the base?

p2p: gives seednode priority over dnsseed if both are provided #11

Conversation

adamjonas commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024

fresheyes-staging-bot bot Mar 24, 2024

Choose a reason for hiding this comment

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot left a comment

Choose a reason for hiding this comment

fresheyes-staging-bot bot commented Mar 24, 2024